Remove defunct __set and __get methods on AbstractAnnotation

Author: DerManoMann

rector.php

@@ -1,5 +1,6 @@
 <?php
 
+use Rector\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector;
 use Rector\CodeQuality\Rector\For_\ForRepeatedCountToOwnVariableRector;
 use Rector\CodeQuality\Rector\If_\CombineIfRector;
 use Rector\CodeQuality\Rector\If_\ExplicitBoolCompareRector;
@@ -37,6 +38,9 @@
             __DIR__ . '/src/Serializer.php',
         ],
         ClassPropertyAssignToConstructorPromotionRector::class,
+        CompleteDynamicPropertiesRector::class => [
+            __DIR__ . '/src/Annotations/AbstractAnnotation.php',
+        ],
     ])
     ->withPreparedSets(
         deadCode: true,

src/Annotations/AbstractAnnotation.php

@@ -151,21 +151,6 @@ public function __construct(array $properties)
         }
     }
 
-    public function __get(string $property)
-    {
-        $properties = get_object_vars($this);
-        $this->_context->logger->warning('Property "' . $property . '" doesn\'t exist in a ' . $this->identity() . ', existing properties: "' . implode('", "', array_keys($properties)) . '" in ' . $this->_context);
-    }
-
-    public function __set(string $property, mixed $value)
-    {
-        $fields = get_object_vars($this);
-        foreach (static::$_blacklist as $_property) {
-            unset($fields[$_property]);
-        }
-        $this->_context->logger->warning('Ignoring unexpected property "' . $property . '" for ' . $this->identity() . ', expecting "' . implode('", "', array_keys($fields)) . '" in ' . $this->_context);
-    }
-
     /**
      * Merge given annotations to their mapped properties configured in static::$_nested.
      *

tests/Annotations/AbstractAnnotationTest.php

@@ -20,15 +20,6 @@ public function testVendorFields(): void
         $this->assertSame(123, $output->$prefixedProperty);
     }
 
-    /**
-     * @requires PHP < 8.2
-     */
-    public function testInvalidField(): void
-    {
-        $this->assertOpenApiLogEntryContains('Ignoring unexpected property "doesnot" for @OA\Get(), expecting');
-        $this->annotationsFromDocBlockParser('@OA\Get(doesnot="exist")');
-    }
-
     public function testUmergedAnnotation(): void
     {
         $openapi = $this->createOpenApiWithInfo();