Favour annotation nullable over native (#1784)

Author: DerManoMann

src/Processors/AugmentProperties.php

@@ -137,7 +137,7 @@ protected function augmentType(Analysis $analysis, OA\Property $property, Contex
 
         // native typehints
         if ($context->type && !Generator::isDefault($context->type)) {
-            if ($context->nullable === true) {
+            if ($context->nullable === true && Generator::isDefault($property->nullable)) {
                 $property->nullable = true;
             }
             $type = strtolower($context->type);

tests/Fixtures/Scratch/Nullable.php

@@ -32,6 +32,9 @@ class Nullable
     #[OAT\Property]
     public ?string $firstname;
 
+    #[OAT\Property(nullable: false)]
+    public ?string $middlename;
+
     #[OAT\Property(nullable: true)]
     public ?string $lastname;
 

tests/Fixtures/Scratch/Nullable3.0.0.yaml

@@ -24,6 +24,9 @@ components:
         firstname:
           type: string
           nullable: true
+        middlename:
+          type: string
+          nullable: false
         lastname:
           type: string
           nullable: true

tests/Fixtures/Scratch/Nullable3.1.0.yaml

@@ -25,6 +25,8 @@ components:
           type:
             - string
             - 'null'
+        middlename:
+          type: string
         lastname:
           type:
             - string