Give ignoreOtherAttributes a dedicated method

Author: DerManoMann

src/Analysers/AttributeAnnotationFactory.php

@@ -36,7 +36,7 @@ public function build(\Reflector $reflector, Context $context): array
         /** @var OA\AbstractAnnotation[] $annotations */
         $annotations = [];
         try {
-            $attributeArgs = $this->generator->getSetting('ignoreOtherAttributes')
+            $attributeArgs = $this->generator->isIgnoreOtherAttributes()
                 ? [OA\AbstractAnnotation::class, \ReflectionAttribute::IS_INSTANCEOF]
                 : [];
 

src/Generator.php

@@ -21,6 +21,15 @@
  *
  * This is an object-oriented alternative to using the now deprecated <code>\OpenApi\scan()</code> function and
  * static class properties of the <code>Analyzer</code> and <code>Analysis</code> classes.
+ *
+ * Supported generator config:
+ * <code>
+ *     [
+ *         'generator' => [
+ *             'ignoreOtherAttributes' => true|false,
+ *         ]
+ *     ]
+ * </code>
  */
 class Generator
 {
@@ -156,12 +165,9 @@ public function getConfig(): array
             ];
     }
 
-    /**
-     * Get the value of a `Generator` setting.
-     */
-    public function getSetting(string $name)
+    public function isIgnoreOtherAttributes(): bool
     {
-        return $this->getConfig()['generator'][$name] ?? null;
+        return $this->getConfig()['generator']['ignoreOtherAttributes'];
     }
 
     protected function normaliseConfig(array $config): array

tests/GeneratorTest.php

@@ -122,14 +122,13 @@ public function testConfig(array $config, bool $expected): void
         $this->assertOperationIdHash($generator, $expected);
     }
 
-    public function testGetSetting(): void
+    public function testIsIgnoreOtherAttributes(): void
     {
         $generator = new Generator();
 
-        // valid; default
-        $this->assertFalse($generator->getSetting('ignoreOtherAttributes'));
+        $this->assertFalse($generator->isIgnoreOtherAttributes());
 
-        // invalid
-        $this->assertNull($generator->getSetting('invalid'));
+        $generator->setConfig(['generator' => ['ignoreOtherAttributes' => true]]);
+        $this->assertTrue($generator->isIgnoreOtherAttributes());
     }
 }