FIX tests for windows#1764
Merged
Merged
Conversation
DerManoMann
requested changes
Apr 25, 2025
DerManoMann
left a comment
Collaborator
There was a problem hiding this comment.
Looking ok to me. Happy to merge if you at least update composer.json
DerManoMann
approved these changes
Apr 27, 2025
DerManoMann
left a comment
Collaborator
There was a problem hiding this comment.
I think there is still an opportunity to use short functions but I feel this will do for now.
v6 will bring some changes to tbe Util class, maybe that is the time to do some more cleanup here.
Collaborator
|
Thanks @srsbiz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes for tests to work in windows environments:
phpto command line testsNULinstead of/dev/nullfor error output in command line tests