Skip to content

FIX tests for windows#1764

Merged
DerManoMann merged 3 commits into
zircote:masterfrom
srsbiz:fix-tests-for-windows
Apr 27, 2025
Merged

FIX tests for windows#1764
DerManoMann merged 3 commits into
zircote:masterfrom
srsbiz:fix-tests-for-windows

Conversation

@srsbiz

@srsbiz srsbiz commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

Summary of changes for tests to work in windows environments:

  • normalized paths where possible for assertions
  • use DIRECTORY_SEPARATOR inside paths where normalization is not possible
  • prepend php to command line tests
  • use NUL instead of /dev/null for error output in command line tests

@DerManoMann DerManoMann left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking ok to me. Happy to merge if you at least update composer.json

Comment thread tests/CommandlineTest.php Outdated
Comment thread tests/UtilTest.php Outdated
@srsbiz srsbiz requested a review from DerManoMann April 26, 2025 12:03

@DerManoMann DerManoMann left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is still an opportunity to use short functions but I feel this will do for now.
v6 will bring some changes to tbe Util class, maybe that is the time to do some more cleanup here.

@DerManoMann DerManoMann merged commit 7a6544c into zircote:master Apr 27, 2025
@DerManoMann

Copy link
Copy Markdown
Collaborator

Thanks @srsbiz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants