Map array<K, V> to type: object + additionalProperties#2002
Closed
krissss wants to merge 1 commit into
Closed
Conversation
…#2001) Distinguish between ordered lists and key-value maps in TypeInfoTypeResolver by checking CollectionType::isList() and keyType. Types with explicit key types (e.g. `array<string, string>`) now produce `type: object` + `additionalProperties` instead of `type: array` + `items`.
Collaborator
|
What happened? |
Contributor
Author
|
Apologies for the confusion — this PR was generated by AI and got pushed before I had a chance to review it carefully. I'm closing it for now and will re-submit after a proper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeInfoTypeResolvernow distinguishes between ordered lists and key-value maps usingCollectionType::isList()andgetCollectionKeyType()array<K, V>(e.g.array<string, string>,array<int, User>) →type: object+additionalPropertiesarray<T>,T[],list<T>→type: array+items(unchanged)array{key: T}shape types also correctly map totype: object+additionalPropertiesCloses #2001
Type of Change
Key Decision
The distinction uses two checks on
CollectionType:isList()→trueforlist<T>(PHP sequential array)getCollectionKeyType() instanceof UnionType→truefor defaultint|stringkeys (array<T>,T[])Anything else (explicit single-type key like
string,int, or a class) is treated as a map.Test Plan
arrayshapeandnullablenestedtypedlistunion)stringMap(array<string, string>) andintKeyedMap(array<int, string>)array<T>,T[],list<T>cases unchanged