[Backport #2003 to 5.x] Map array<K, V> to type: object + additionalProperties#2006
Closed
github-actions[bot] wants to merge 1 commit into
Closed
[Backport #2003 to 5.x] Map array<K, V> to type: object + additionalProperties#2006github-actions[bot] wants to merge 1 commit into
array<K, V> to type: object + additionalProperties#2006github-actions[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-2003-to-5.x
git worktree add --checkout .worktree/backport-2003-to-5.x backport-2003-to-5.x
cd .worktree/backport-2003-to-5.x
git reset --hard HEAD^
git cherry-pick -x f66289ab9c9c3a1cf70222e0bebbe7c6c7109f2f |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #2003 to branch
5.x.Closes #2001
Summary
TypeInfoTypeResolvernow mapsarray<K, V>(with explicit key type) totype: object+additionalPropertiesinstead oftype: array+itemsarray<T>,T[],list<T>(defaultint|stringkey) keep existingtype: array+itemsbehaviourArrayShapeType(e.g.array{foo:bool}) also correctly resolves totype: object+additionalPropertiesLegacyTypeResolveris not affected — it continues to producetype: array+itemsfor all array typesTest plan
TypeResolverTest— 152 tests pass (both 3.0.0 and 3.1.0, both legacy and type-info resolvers)AugmentPropertiesTest— map assertion merged intotestTypedPropertiesarray<int, T>in union types correctly producesobject+additionalProperties