fix: remove redundant is_array() check in Serializer#2020
Merged
DerManoMann merged 1 commit intoJun 12, 2026
Conversation
Restructure the declaration type checks in doDeserializeProperty() to use if/elseif branching on is_string($declaration), so PHPStan can narrow the type and the is_array() guard is no longer needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Successfully created backport PR for |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_array()on$declarationalways evaluates to true inSerializer::doDeserializeProperty()is_string($declaration)with a separateif, the subsequentis_array()checks were redundant since the type union isstring|array<string>if/elseifbranching so the string case is handled first and the array branches follow naturally without needing explicitis_array()guardsTest plan
composer analyse— 0 errorscomposer test— 1037 tests pass🤖 Generated with Claude Code