[Backport #2018 to 5.x] fix: resolve Schema ref from parameter type in AugmentRequestBody#2022
Closed
github-actions[bot] wants to merge 1 commit into
Closed
[Backport #2018 to 5.x] fix: resolve Schema ref from parameter type in AugmentRequestBody#2022github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
) (cherry picked from commit 57378fe)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #2018 to branch
5.x.Summary
#[OA\RequestBody]is on a method parameter whose type has a#[OA\Schema]annotation, the existingaugmentSchemaType+type2reflookup fails because it searches for aRequestBodyannotation on the class$refwhen ref remains UNDEFINED after the existing logicDetails
Problem:
augmentSchemaTypecallstype2ref($schema, $analysis, $sourceClass)where$sourceClass = OA\RequestBody::class. Insidetype2ref,getAnnotationForSourcelooks for aRequestBodyannotation on the class — but the class has aSchemaannotation, so it returns null and the ref stays unresolved.Fix: After the existing
augmentSchemaTypecall, ifrefis still UNDEFINED, use reflection to get the parameter type and look up aSchemaannotation directly via$analysis->getAnnotationForSource($className, OA\Schema::class).Backwards compatibility:
augmentSchemaType+ RequestBody lookup still runs first (unchanged)#[OA\RequestBody]Test plan
Scratch/RequestBodyfixture with newpostSchemaParamendpoint🤖 Generated with Claude Code