Fix CleanUnusedComponents removing schemas referenced via JsonContent#2047
Open
DerManoMann wants to merge 1 commit into
Open
Fix CleanUnusedComponents removing schemas referenced via JsonContent#2047DerManoMann wants to merge 1 commit into
DerManoMann wants to merge 1 commit into
Conversation
… JsonContent/XmlContent MergeJsonContent removes JsonContent from $analysis->annotations but keeps it as the schema property of MediaType. The performance refactor in zircote#2030 stopped traversing nested annotation properties, making those refs invisible to the unused-components check. This caused schemas only referenced via JsonContent (or XmlContent) to be incorrectly removed. Fix by recursively collecting refs from annotation properties (with cycle protection). Also guard against "Cannot unset string offsets" crash and deduplicate $_nested componentType iteration. Fixes zircote#2046 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CleanUnusedComponentsincorrectly removing schemas that are only referenced viaJsonContent(ref: ...)orXmlContent(ref: ...). The performance refactor in Fix/clean unused components performance #2030 stopped traversing nested annotation properties, making those refs invisible sinceMergeJsonContentremoves theJsonContentfrom$analysis->annotations(but keeps it asMediaType->schema).UNDEFINED.$_nestedcomponentType iteration (Parameter/PathParameterboth map to'parameters').JsonContent, properly exercising the new traversal path.Fixes #2046
🤖 Generated with Claude Code