chore: package upgrades#866
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Go dependencies to newer patch releases and adapts OIDC/JWKS handling to accommodate breaking error-type changes in go-jose/v4.
Changes:
- Bumps
go-jose/v4(and other deps like OpenTelemetry andx/*) ingo.mod/go.sum. - Updates signature parsing error handling to map new
go-joseerror types to existing library errors. - Updates JWKS unmarshalling to ignore unsupported key types using
errors.Is, and adjusts related tests.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/oidc/verifier.go | Updates ParseSigned error classification for unsupported/unknown signature algorithms after go-jose error changes. |
| pkg/client/rp/jwks.go | Switches JWKS unknown key-type handling from string-prefix matching to errors.Is with go-jose sentinel error. |
| pkg/client/rp/jwks_test.go | Updates test expectations to align with the new go-jose error handling behavior. |
| go.mod | Upgrades direct and indirect dependency versions (notably go-jose/v4, OpenTelemetry, and x/*). |
| go.sum | Updates module checksums corresponding to the dependency bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/zitadel/oidc/sessions/e88e2185-ddaa-457f-8595-c4527aaf2e5a Co-authored-by: wim07101993 <23017340+wim07101993@users.noreply.github.com>
muhlemmer
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded all packages to latest patch versions.
For jose there was a breaking change in errors.
errors.AsforErrUnexpectedSignatureAlgorithmso wrapped errors are handled consistently.errors.Is.jwks_test.goto useassert.NotErrorIsfor proper error identity checking instead of brittle string matching.Definition of Ready