Skip to content

chore: package upgrades#866

Merged
muhlemmer merged 3 commits into
mainfrom
chore/package-upgrades
Apr 8, 2026
Merged

chore: package upgrades#866
muhlemmer merged 3 commits into
mainfrom
chore/package-upgrades

Conversation

@wim07101993
Copy link
Copy Markdown
Member

@wim07101993 wim07101993 commented Apr 3, 2026

Upgraded all packages to latest patch versions.
For jose there was a breaking change in errors.

  • Updated signature parsing error handling to use errors.As for ErrUnexpectedSignatureAlgorithm so wrapped errors are handled consistently.
  • Updated JWKS unmarshalling to ignore unsupported key types using errors.Is.
  • Improved test assertions in jwks_test.go to use assert.NotErrorIs for proper error identity checking instead of brittle string matching.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Go dependencies to newer patch releases and adapts OIDC/JWKS handling to accommodate breaking error-type changes in go-jose/v4.

Changes:

  • Bumps go-jose/v4 (and other deps like OpenTelemetry and x/*) in go.mod/go.sum.
  • Updates signature parsing error handling to map new go-jose error types to existing library errors.
  • Updates JWKS unmarshalling to ignore unsupported key types using errors.Is, and adjusts related tests.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pkg/oidc/verifier.go Updates ParseSigned error classification for unsupported/unknown signature algorithms after go-jose error changes.
pkg/client/rp/jwks.go Switches JWKS unknown key-type handling from string-prefix matching to errors.Is with go-jose sentinel error.
pkg/client/rp/jwks_test.go Updates test expectations to align with the new go-jose error handling behavior.
go.mod Upgrades direct and indirect dependency versions (notably go-jose/v4, OpenTelemetry, and x/*).
go.sum Updates module checksums corresponding to the dependency bumps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/oidc/verifier.go Outdated
Comment thread pkg/client/rp/jwks_test.go
wim07101993 and others added 2 commits April 3, 2026 12:41
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@muhlemmer muhlemmer merged commit 0bf0ade into main Apr 8, 2026
5 checks passed
@muhlemmer muhlemmer deleted the chore/package-upgrades branch April 8, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants