Skip to content

Commit 09e0809

Browse files
AlexU-Aclaude
andcommitted
feat: add JTBD descriptions to all critics, skills, and manifests
- Update frontmatter descriptions in all 5 agents and 4 skills to JTBD-oriented phrasing that tells agents when/why to invoke each critic - Add "Jobs To Be Done" sections to all 4 SKILL.md files with concrete trigger scenarios and router dispatch context - Add jtbd: field to all 43 skill entries across 4 external-skills manifests - Expand all 4 skill-routing-maps with JTBD annotations per skill - Reframe visual explainer hero from security focus to value proposition Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent f0b5835 commit 09e0809

18 files changed

Lines changed: 189 additions & 84 deletions

.claude/agents/js-critic-router.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: js-critic-router
3-
description: Routes JavaScript/TypeScript review requests to the appropriate specialist critic (react-critic, next-critic, react-native-critic, or proposal-critic) based on framework signals, file paths, imports, and artifact type.
3+
description: "Use as the entry point for any JavaScript/TypeScript code review or plan critique. Reads imports, file paths, package.json, and document signals to dispatch to the right specialist critic (react-critic, next-critic, react-native-critic, or proposal-critic). Invoke this instead of picking a critic directly."
44
model: claude-haiku-4-5
55
disallowedTools: Write, Edit
66
---

.claude/agents/next-critic.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: next-critic
3-
description: Next.js App Router-focused harsh reviewer with evidence-backed findings and context-driven audience lenses
3+
description: "Use when reviewing Next.js App Router code, RSC boundaries, cache/revalidation behavior, route handlers, server actions, runtime decisions, and upgrade plans where evidence-backed critique is required."
44
model: claude-opus-4-6
55
disallowedTools: Write, Edit
66
---

.claude/agents/proposal-critic.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: proposal-critic
3-
description: Plan-first harsh reviewer for technical proposals, ADRs, RFCs, and migration specs across the React ecosystem
3+
description: "Use when reviewing RFCs, ADRs, migration plans, architecture decisions, or feature specs across the React ecosystem where evidence-backed plan critique is required."
44
model: claude-opus-4-6
55
disallowedTools: Write, Edit
66
---

.claude/agents/react-critic.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: react-critic
3-
description: React-specific harsh reviewer with evidence-backed findings and context-driven audience lenses
3+
description: "Use when reviewing React components, hooks, state management, rendering performance, or upgrade plans where evidence-backed critique with security/new-hire/ops perspectives is required."
44
model: claude-opus-4-6
55
disallowedTools: Write, Edit
66
---

.claude/agents/react-native-critic.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: react-native-critic
3-
description: React Native and Expo-focused harsh reviewer with evidence-backed findings and context-driven audience lenses
3+
description: "Use when reviewing React Native or Expo code for native performance, platform APIs, mobile architecture, upgrade safety, and release workflows where evidence-backed critique is required."
44
model: claude-opus-4-6
55
disallowedTools: Write, Edit
66
---

.claude/skills/next-critic/SKILL.md

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,28 @@
11
---
22
name: next-critic
3-
description: Next.js App Router-specific harsh review orchestration for plans, code, and implementation notes. Use when reviewing RSC boundaries, cache/revalidation behavior, route handlers/server actions, runtime decisions, and upgrade plans where evidence-backed critique is required.
3+
description: "Use when reviewing Next.js App Router code, RSC boundaries, cache/revalidation behavior, route handlers, server actions, runtime decisions, and upgrade plans where evidence-backed critique is required."
44
---
55

66
# Next Critic
77

88
## Overview
99
Run a harsh-critic style review with Next.js App Router checks, explicit evidence requirements, and context-driven audience perspectives.
1010

11+
## Jobs To Be Done
12+
13+
Use next-critic when you need to:
14+
15+
- **Review App Router architecture** — layout nesting, parallel routes, intercepting routes, loading/error boundaries
16+
- **Audit RSC boundaries**`'use client'`/`'use server'` placement, serialization across the boundary, component tree splits
17+
- **Evaluate caching and revalidation** — fetch cache, ISR, `revalidatePath`/`revalidateTag`, on-demand revalidation strategy
18+
- **Review server actions and route handlers** — mutation patterns, error handling, redirect behavior, form actions
19+
- **Catch runtime configuration issues** — edge vs Node.js runtime choices, middleware behavior, streaming pitfalls
20+
- **Assess auth integration** — Clerk, Auth0, or NextAuth.js patterns, session handling, protected routes
21+
- **Review Next.js version upgrades** — breaking changes between versions, codemods, migration scope
22+
- **Evaluate data fetching patterns** — waterfall risk, parallel fetching, server component data loading, Suspense boundaries
23+
24+
The router (`js-critic-router`) dispatches here when it detects: `next` in package.json, App Router conventions (`app/**/page.tsx`), Pages Router conventions, Next.js APIs (`next/navigation`, `next/cache`), or `next.config.*`.
25+
1126
## External Skill References (No Copy Policy)
1227
Use external skills as references only.
1328

.claude/skills/next-critic/references/external-skills-manifest.yaml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ skills:
1515
- performance-engineer
1616
priority: 100
1717
status: active
18+
jtbd: "Load for any Next.js review — core App Router patterns, RSC best practices, and data fetching guidance from Vercel."
1819
- id: vercel-labs/next-skills/next-cache-components
1920
skills_url: https://skills.sh/vercel-labs/next-skills/next-cache-components
2021
repo_url: https://github.com/vercel-labs/next-skills
@@ -27,6 +28,7 @@ skills:
2728
- performance-engineer
2829
priority: 95
2930
status: active
31+
jtbd: "Load when reviewing caching, ISR, revalidation strategies, or fetch cache behavior in Next.js."
3032
- id: vercel-labs/next-skills/next-upgrade
3133
skills_url: https://skills.sh/vercel-labs/next-skills/next-upgrade
3234
repo_url: https://github.com/vercel-labs/next-skills
@@ -39,6 +41,7 @@ skills:
3941
- dx-maintainer
4042
priority: 92
4143
status: active
44+
jtbd: "Load when reviewing Next.js version upgrades, breaking changes, codemods, or migration plans."
4245
- id: wshobson/agents/nextjs-app-router-patterns
4346
skills_url: https://skills.sh/wshobson/agents/nextjs-app-router-patterns
4447
repo_url: https://github.com/wshobson/agents
@@ -51,6 +54,7 @@ skills:
5154
- ops
5255
priority: 88
5356
status: active
57+
jtbd: "Load when reviewing App Router architecture — layout nesting, parallel routes, route groups, and advanced patterns."
5458
- id: wsimmonds/claude-nextjs-skills/nextjs-app-router-fundamentals
5559
skills_url: https://skills.sh/wsimmonds/claude-nextjs-skills/nextjs-app-router-fundamentals
5660
repo_url: https://github.com/wsimmonds/claude-nextjs-skills
@@ -62,6 +66,7 @@ skills:
6266
- new-hire
6367
priority: 82
6468
status: active
69+
jtbd: "Load when reviewing App Router fundamentals — server/client component split, basic routing, and data flow patterns."
6570
- id: clerk/skills/clerk-nextjs-patterns
6671
skills_url: https://skills.sh/clerk/skills/clerk-nextjs-patterns
6772
repo_url: https://github.com/clerk/skills
@@ -73,6 +78,7 @@ skills:
7378
- security
7479
priority: 78
7580
status: active
81+
jtbd: "Load when code uses Clerk for authentication — middleware setup, protected routes, and session management patterns."
7682
- id: auth0/agent-skills/auth0-nextjs
7783
skills_url: https://skills.sh/auth0/agent-skills/auth0-nextjs
7884
repo_url: https://github.com/auth0/agent-skills
@@ -84,6 +90,7 @@ skills:
8490
- security
8591
priority: 78
8692
status: active
93+
jtbd: "Load when code uses Auth0 for authentication — SDK integration, callback handling, and session patterns for Next.js."
8794
- id: mindrally/skills/nextauth-authentication
8895
skills_url: https://skills.sh/mindrally/skills/nextauth-authentication
8996
repo_url: https://github.com/mindrally/skills
@@ -95,6 +102,7 @@ skills:
95102
- security
96103
priority: 76
97104
status: active
105+
jtbd: "Load when code uses NextAuth.js / Auth.js — provider configuration, session strategy, and callback patterns."
98106
- id: wshobson/agents/javascript-testing-patterns
99107
skills_url: https://skills.sh/wshobson/agents/javascript-testing-patterns
100108
repo_url: https://github.com/wshobson/agents
@@ -106,6 +114,7 @@ skills:
106114
- ops
107115
priority: 86
108116
status: active
117+
jtbd: "Load when reviewing test strategy, async test patterns, or coverage gaps in JavaScript/TypeScript projects."
109118
- id: wshobson/agents/modern-javascript-patterns
110119
skills_url: https://skills.sh/wshobson/agents/modern-javascript-patterns
111120
repo_url: https://github.com/wshobson/agents
@@ -117,6 +126,7 @@ skills:
117126
- new-hire
118127
priority: 76
119128
status: active
129+
jtbd: "Load when reviewing modern JS idioms — ESM usage, async patterns, and contemporary language features."
120130
- id: sickn33/antigravity-awesome-skills/api-security-best-practices
121131
skills_url: https://skills.sh/sickn33/antigravity-awesome-skills/api-security-best-practices
122132
repo_url: https://github.com/sickn33/antigravity-awesome-skills
@@ -128,3 +138,4 @@ skills:
128138
- security
129139
priority: 72
130140
status: active
141+
jtbd: "Load when code handles API boundaries, auth tokens, user input, or sensitive data — trust boundary and input validation patterns."

.claude/skills/next-critic/references/skill-routing-map.md

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
# Next Critic Skill Routing Map
22

3-
Core:
4-
- vercel-labs/next-skills/next-best-practices
3+
Core (always loaded):
4+
- vercel-labs/next-skills/next-best-practices — core Next.js App Router patterns and data fetching from Vercel
55

6-
Specialists:
7-
- vercel-labs/next-skills/next-cache-components
8-
- vercel-labs/next-skills/next-upgrade
9-
- wshobson/agents/nextjs-app-router-patterns
10-
- wsimmonds/claude-nextjs-skills/nextjs-app-router-fundamentals
6+
Specialists (load one based on context):
7+
- vercel-labs/next-skills/next-cache-components — when reviewing caching, ISR, or revalidation behavior
8+
- vercel-labs/next-skills/next-upgrade — when reviewing Next.js version upgrades or migrations
9+
- wshobson/agents/nextjs-app-router-patterns — when reviewing advanced App Router architecture patterns
10+
- wsimmonds/claude-nextjs-skills/nextjs-app-router-fundamentals — when reviewing basic App Router component structure
1111

12-
Auth conditional:
13-
- clerk/skills/clerk-nextjs-patterns
14-
- auth0/agent-skills/auth0-nextjs
15-
- mindrally/skills/nextauth-authentication
12+
Auth conditional (load when auth imports detected):
13+
- clerk/skills/clerk-nextjs-patterns — when Clerk imports are present
14+
- auth0/agent-skills/auth0-nextjs — when Auth0 imports are present
15+
- mindrally/skills/nextauth-authentication — when NextAuth.js / Auth.js imports are present
1616

17-
Shared support:
18-
- wshobson/agents/javascript-testing-patterns
19-
- wshobson/agents/modern-javascript-patterns
20-
- sickn33/antigravity-awesome-skills/api-security-best-practices
17+
Shared support (load one):
18+
- wshobson/agents/javascript-testing-patterns — when reviewing test strategy or coverage gaps
19+
- wshobson/agents/modern-javascript-patterns — when reviewing modern JS idioms and async patterns
20+
- sickn33/antigravity-awesome-skills/api-security-best-practices — when code handles API boundaries or sensitive data
2121

2222
Rules:
2323
- Load max 3 skills: 1 core + 1 context specialist + 1 shared support.

.claude/skills/proposal-critic/SKILL.md

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,29 @@
11
---
22
name: proposal-critic
3-
description: Plan-first harsh review orchestration for technical proposals, ADRs, RFCs, migration plans, and architecture decision records across the React ecosystem. Use when reviewing any pre-implementation artifact — proposals, specs, design docs, migration plans, feature briefs, or refactor RFCs — where evidence-backed plan critique is required.
3+
description: "Use when reviewing RFCs, ADRs, migration plans, architecture decisions, or feature specs across the React ecosystem where evidence-backed plan critique is required."
44
---
55

66
# Proposal Critic
77

88
## Overview
99
Run a harsh-critic style plan review for technical proposals and decision records across the React, Next.js, and React Native/Expo ecosystem. This critic is plan-first by default: every review is a plan review. Never downgrade findings because code hasn't been written yet — underspecified proposals are a category of risk, not a grace period.
1010

11+
## Jobs To Be Done
12+
13+
Use proposal-critic when you need to:
14+
15+
- **Review RFCs and ADRs** — alternatives analysis, assumption extraction, hidden constraints, and decision justification
16+
- **Critique migration plans** — rollback strategy, phased rollout risks, dependency ordering, blast radius of each phase
17+
- **Evaluate architecture decisions** — boundary definitions, coupling risks, scalability assumptions, and devil's-advocate challenges
18+
- **Assess feature specs** — feasibility, ambiguity scan, missing acceptance criteria, and implementation risk
19+
- **Pre-mortem analysis** — identify how the plan could fail before resources are committed
20+
- **Dependency audit** — surface hidden dependencies, version assumptions, and integration risks across the plan
21+
- **Review refactor proposals** — scope creep risk, test coverage implications, and incremental delivery strategy
22+
23+
The router (`js-critic-router`) dispatches here when it detects: pre-implementation documents with signal phrases like "we propose", "alternatives considered", "rollback strategy", "RFC", "ADR", or "migration plan" — with no real code or only illustrative pseudocode.
24+
25+
Uses **executor/stakeholder/skeptic** perspectives instead of the standard security/new-hire/ops lenses.
26+
1127
## External Skill References (No Copy Policy)
1228
Use external skills as references only.
1329

.claude/skills/proposal-critic/references/external-skills-manifest.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ skills:
1515
- skeptic
1616
priority: 92
1717
status: active
18+
jtbd: "Load when evaluating architecture proposals — provides cross-framework architectural patterns and boundary analysis."
1819
- id: dotneet/claude-code-marketplace/typescript-react-reviewer
1920
skills_url: https://skills.sh/dotneet/claude-code-marketplace/typescript-react-reviewer
2021
repo_url: https://github.com/dotneet/claude-code-marketplace
@@ -28,6 +29,7 @@ skills:
2829
- dx-maintainer
2930
priority: 78
3031
status: active
32+
jtbd: "Load when evaluating TypeScript API design proposals — type safety patterns and interface design review."
3133
- id: wshobson/agents/modern-javascript-patterns
3234
skills_url: https://skills.sh/wshobson/agents/modern-javascript-patterns
3335
repo_url: https://github.com/wshobson/agents
@@ -40,6 +42,7 @@ skills:
4042
- skeptic
4143
priority: 76
4244
status: active
45+
jtbd: "Load when evaluating JS/TS pattern choices in proposals — modern idioms and contemporary language feature assessment."
4346
- id: sickn33/antigravity-awesome-skills/api-security-best-practices
4447
skills_url: https://skills.sh/sickn33/antigravity-awesome-skills/api-security-best-practices
4548
repo_url: https://github.com/sickn33/antigravity-awesome-skills
@@ -51,6 +54,7 @@ skills:
5154
- security-engineer
5255
priority: 72
5356
status: active
57+
jtbd: "Load when proposals involve API design, auth flows, or data handling — security architecture and trust boundary review."
5458
- id: wshobson/agents/javascript-testing-patterns
5559
skills_url: https://skills.sh/wshobson/agents/javascript-testing-patterns
5660
repo_url: https://github.com/wshobson/agents
@@ -62,3 +66,4 @@ skills:
6266
- executor
6367
priority: 70
6468
status: active
69+
jtbd: "Load when evaluating test strategy feasibility in proposals — coverage planning and test architecture assessment."

0 commit comments

Comments
 (0)