Skip to content

Commit 1272f79

Browse files
authored
Merge branch 'main' into optimize-spill-performance
2 parents 5ef21f3 + 0c055a3 commit 1272f79

6 files changed

Lines changed: 9 additions & 5 deletions

File tree

src/paimon/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ set(PAIMON_COMMON_SRCS
124124
common/types/data_type_json_parser.cpp
125125
common/types/row_kind.cpp
126126
common/types/row_type.cpp
127+
common/utils/file_type.cpp
127128
common/utils/arrow/arrow_input_stream_adapter.cpp
128129
common/utils/arrow/arrow_output_stream_adapter.cpp
129130
common/utils/arrow/arrow_utils.cpp
@@ -467,6 +468,7 @@ if(PAIMON_BUILD_TESTS)
467468
common/types/data_type_json_parser_test.cpp
468469
common/types/row_kind_test.cpp
469470
common/types/data_type_test.cpp
471+
common/utils/file_type_test.cpp
470472
common/utils/row_range_index_test.cpp
471473
common/utils/var_length_int_utils_test.cpp
472474
common/utils/arrow/arrow_utils_test.cpp

src/paimon/core/io/field_mapping_reader_test.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,7 @@ TEST_F(FieldMappingReaderTest, TestReadWithSchemaEvolutionPureRename) {
610610
DataField(1, arrow::field("f1", arrow::int32()))};
611611
auto data_schema = DataField::ConvertDataFieldsToArrowSchema(data_fields);
612612
auto data_array = std::dynamic_pointer_cast<arrow::StructArray>(
613-
arrow::ipc::internal::json::ArrayFromJSON(arrow::struct_({data_schema->fields()}),
613+
arrow::ipc::internal::json::ArrayFromJSON(arrow::struct_(data_schema->fields()),
614614
R"([
615615
["Alice", 1],
616616
["Bob", 2],
@@ -626,7 +626,7 @@ TEST_F(FieldMappingReaderTest, TestReadWithSchemaEvolutionPureRename) {
626626
// Expected output uses the post-rename names; verifies mapping actually
627627
// ran (PASSTHRU would keep f0/f1 and Equals would fail).
628628
auto expected = std::dynamic_pointer_cast<arrow::StructArray>(
629-
arrow::ipc::internal::json::ArrayFromJSON(arrow::struct_({read_schema->fields()}),
629+
arrow::ipc::internal::json::ArrayFromJSON(arrow::struct_(read_schema->fields()),
630630
R"([
631631
["Alice", 1],
632632
["Bob", 2],

src/paimon/core/mergetree/lookup/persist_processor_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ TEST_F(PersistProcessorTest, TestValueProcessor) {
111111
"Not support for PersistToDisk with position");
112112
}
113113

114-
TEST_F(PersistProcessorTest, TestInvalideValueProcessor) {
114+
TEST_F(PersistProcessorTest, TestInvalidValueProcessor) {
115115
std::shared_ptr<arrow::Schema> current_schema =
116116
arrow::schema({arrow::field("f0", arrow::utf8()), arrow::field("f1", arrow::int32()),
117117
arrow::field("f2", arrow::int32()), arrow::field("f3", arrow::float32())});

src/paimon/core/snapshot_test.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,7 @@ TEST_F(SnapshotTest, TestSerializeAndDeserialize) {
243243
se_and_de_from_str(json_str);
244244
}
245245
}
246+
246247
TEST_F(SnapshotTest, TestCommitKindAnalyze) {
247248
// Test constructing a Snapshot with CommitKind::Analyze
248249
Snapshot snapshot(

src/paimon/format/parquet/parquet_file_batch_reader.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ Status ParquetFileBatchReader::SetReadSchema(
153153
read_column_indices_ = column_indices;
154154

155155
metrics_->SetCounter(ParquetMetrics::READ_ROW_GROUPS_TOTAL, reader_->GetNumberOfRowGroups());
156-
metrics_->SetCounter(ParquetMetrics::READ_ROW_GROUPS_FILTERED, row_groups.size());
156+
metrics_->SetCounter(ParquetMetrics::READ_ROW_GROUPS_AFTER_FILTER, row_groups.size());
157157

158158
PAIMON_ASSIGN_OR_RAISE(std::set<int32_t> ordered_row_groups,
159159
reader_->FilterRowGroupsByReadRanges(read_ranges_, read_row_groups_));

src/paimon/format/parquet/parquet_format_defs.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ class ParquetMetrics {
6565

6666
// read
6767
static inline const char READ_ROW_GROUPS_TOTAL[] = "parquet.read.row-groups.total";
68-
static inline const char READ_ROW_GROUPS_FILTERED[] = "parquet.read.row-groups.filtered";
68+
static inline const char READ_ROW_GROUPS_AFTER_FILTER[] =
69+
"parquet.read.row-groups.after-filter";
6970
static inline const char READ_ROWS[] = "parquet.read.rows";
7071
static inline const char READ_BATCH_COUNT[] = "parquet.read.batch-count";
7172
};

0 commit comments

Comments
 (0)