Skip to content

Commit c84168c

Browse files
committed
fix(build): harden build script paths
1 parent 3cb4556 commit c84168c

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

ci/scripts/build_paimon.sh

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ source_dir=${1}
2020
enable_sanitizer=${2:-false}
2121
check_clang_tidy=${3:-false}
2222
build_type=${4:-Debug}
23-
build_dir=${1}/build
23+
build_dir="${source_dir}/build"
2424

2525
# Display ccache status if available
2626
if command -v ccache &> /dev/null; then
@@ -31,8 +31,8 @@ else
3131
echo "=== ccache not found, compiling without cache acceleration ==="
3232
fi
3333

34-
mkdir ${build_dir}
35-
pushd ${build_dir}
34+
mkdir -p "${build_dir}"
35+
pushd "${build_dir}"
3636

3737
ENABLE_LUMINA="ON"
3838
ENABLE_LANCE="ON"
@@ -62,9 +62,9 @@ if [[ "${enable_sanitizer}" == "true" ]]; then
6262
)
6363
fi
6464

65-
cmake "${CMAKE_ARGS[@]}" ${source_dir}
66-
cmake --build . -- -j$(nproc)
67-
ctest --output-on-failure -j $(nproc)
65+
cmake "${CMAKE_ARGS[@]}" "${source_dir}"
66+
cmake --build . -- -j "$(nproc)"
67+
ctest --output-on-failure -j "$(nproc)"
6868

6969
if [[ "${check_clang_tidy}" == "true" ]]; then
7070
cmake --build . --target check-clang-tidy
@@ -78,4 +78,4 @@ fi
7878

7979
popd
8080

81-
rm -rf ${build_dir}
81+
rm -rf "${build_dir}"

0 commit comments

Comments
 (0)