fix(cmake): fix LOWERCASE_BUILD_TYPE definition and usage (alibaba#180)

This commit fixes several issues with CMAKE_BUILD_TYPE_LOWER variable:

1. Duplicate definitions: The variable was defined twice in the file
   - Line 1094 in Arrow build section
   - Line 1315 in TBB build section

2. Use-before-definition bug: In TBB section, line 1304 used the
   variable before it was defined on line 1315

3. Inconsistent naming: Renamed CMAKE_BUILD_TYPE_LOWER to
   LOWERCASE_BUILD_TYPE to match the naming style of
   UPPERCASE_BUILD_TYPE

The fix consolidates the definition at the top of the file (line 33),
right after UPPERCASE_BUILD_TYPE, ensuring it's available throughout
the file and following a consistent naming convention.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: mrdrivingduck

cmake_modules/ThirdpartyToolchain.cmake

@@ -30,6 +30,7 @@ if(CMAKE_GENERATOR_TOOLSET)
 endif()
 
 string(TOUPPER ${CMAKE_BUILD_TYPE} UPPERCASE_BUILD_TYPE)
+string(TOLOWER ${CMAKE_BUILD_TYPE} LOWERCASE_BUILD_TYPE)
 
 set(EP_COMMON_TOOLCHAIN "-DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}"
                         "-DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}")
@@ -1091,7 +1092,6 @@ macro(build_arrow)
     file(MAKE_DIRECTORY "${ARROW_INCLUDE_DIR}")
 
     set(ARROW_BUILD_DIR "${CMAKE_BINARY_DIR}/arrow")
-    string(TOLOWER ${CMAKE_BUILD_TYPE} CMAKE_BUILD_TYPE_LOWER)
     set(ARROW_STATIC_LIB
         "${ARROW_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}arrow${CMAKE_STATIC_LIBRARY_SUFFIX}"
     )
@@ -1164,38 +1164,38 @@ macro(build_arrow)
                           PROPERTIES IMPORTED_LOCATION "${ARROW_PREFIX}/lib/libarrow.a"
                                      INTERFACE_INCLUDE_DIRECTORIES "${ARROW_INCLUDE_DIR}"
                                      INTERFACE_LINK_DIRECTORIES
-                                     "${ARROW_BUILD_DIR}/${CMAKE_BUILD_TYPE_LOWER}")
+                                     "${ARROW_BUILD_DIR}/${LOWERCASE_BUILD_TYPE}")
 
     add_library(arrow_dataset STATIC IMPORTED)
     set_target_properties(arrow_dataset
                           PROPERTIES IMPORTED_LOCATION
                                      "${ARROW_PREFIX}/lib/libarrow_dataset.a"
                                      INTERFACE_INCLUDE_DIRECTORIES "${ARROW_INCLUDE_DIR}"
                                      INTERFACE_LINK_DIRECTORIES
-                                     "${ARROW_BUILD_DIR}/${CMAKE_BUILD_TYPE_LOWER}")
+                                     "${ARROW_BUILD_DIR}/${LOWERCASE_BUILD_TYPE}")
 
     add_library(arrow_acero STATIC IMPORTED)
     set_target_properties(arrow_acero
                           PROPERTIES IMPORTED_LOCATION
                                      "${ARROW_PREFIX}/lib/libarrow_acero.a"
                                      INTERFACE_INCLUDE_DIRECTORIES "${ARROW_INCLUDE_DIR}"
                                      INTERFACE_LINK_DIRECTORIES
-                                     "${ARROW_BUILD_DIR}/${CMAKE_BUILD_TYPE_LOWER}")
+                                     "${ARROW_BUILD_DIR}/${LOWERCASE_BUILD_TYPE}")
 
     add_library(parquet STATIC IMPORTED)
     set_target_properties(parquet
                           PROPERTIES IMPORTED_LOCATION "${ARROW_PREFIX}/lib/libparquet.a"
                                      INTERFACE_INCLUDE_DIRECTORIES "${ARROW_INCLUDE_DIR}"
                                      INTERFACE_LINK_DIRECTORIES
-                                     "${ARROW_BUILD_DIR}/${CMAKE_BUILD_TYPE_LOWER}")
+                                     "${ARROW_BUILD_DIR}/${LOWERCASE_BUILD_TYPE}")
 
     add_library(arrow_bundled_dependencies STATIC IMPORTED)
     set_target_properties(arrow_bundled_dependencies
                           PROPERTIES IMPORTED_LOCATION
                                      "${ARROW_PREFIX}/lib/libarrow_bundled_dependencies.a"
                                      INTERFACE_INCLUDE_DIRECTORIES "${ARROW_INCLUDE_DIR}"
                                      INTERFACE_LINK_DIRECTORIES
-                                     "${ARROW_BUILD_DIR}/${CMAKE_BUILD_TYPE_LOWER}")
+                                     "${ARROW_BUILD_DIR}/${LOWERCASE_BUILD_TYPE}")
 
     add_dependencies(arrow arrow_ep)
     add_dependencies(parquet arrow_ep)
@@ -1238,7 +1238,7 @@ macro(build_gtest)
     # Library and runtime same on non-Windows
     set(_GTEST_LIBRARY_DIR "${_GTEST_RUNTIME_DIR}")
 
-    if(CMAKE_BUILD_TYPE_LOWER STREQUAL "debug")
+    if(LOWERCASE_BUILD_TYPE STREQUAL "debug")
         set(GTEST_STATIC_LIB "${GTEST_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}gtestd.a")
         set(GMOCK_STATIC_LIB "${GTEST_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}gmockd.a")
         set(GTEST_MAIN_STATIC_LIB
@@ -1301,7 +1301,7 @@ macro(build_tbb)
 
     set(TBB_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/tbb_ep-install")
 
-    if(CMAKE_BUILD_TYPE_LOWER STREQUAL "debug")
+    if(LOWERCASE_BUILD_TYPE STREQUAL "debug")
         set(TBB_STATIC_LIB "${TBB_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}tbb_debug.a")
     else()
         set(TBB_STATIC_LIB "${TBB_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}tbb.a")
@@ -1312,8 +1312,6 @@ macro(build_tbb)
 
     set(TBB_BUILD_DIR "${CMAKE_BINARY_DIR}/tbb")
 
-    string(TOLOWER ${CMAKE_BUILD_TYPE} CMAKE_BUILD_TYPE_LOWER)
-
     set(TBB_CMAKE_ARGS
         ${EP_COMMON_CMAKE_ARGS}
         "-DCMAKE_INSTALL_PREFIX=${TBB_PREFIX}"
@@ -1333,7 +1331,7 @@ macro(build_tbb)
                           PROPERTIES IMPORTED_LOCATION "${TBB_STATIC_LIB}"
                                      INTERFACE_INCLUDE_DIRECTORIES "${TBB_INCLUDE_DIR}"
                                      INTERFACE_LINK_DIRECTORIES
-                                     "${TBB_BUILD_DIR}/${CMAKE_BUILD_TYPE_LOWER}")
+                                     "${TBB_BUILD_DIR}/${LOWERCASE_BUILD_TYPE}")
     add_dependencies(tbb tbb_ep)
 
 endmacro(build_tbb)