Skip to content

Commit f4c376b

Browse files
committed
fix
1 parent 29acd08 commit f4c376b

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

src/paimon/common/utils/path_util.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ class PAIMON_EXPORT PathUtil {
3939
~PathUtil() = delete;
4040

4141
static std::string JoinPath(const std::string& path, const std::string& name) noexcept;
42+
// TODO(jinli.zjw): should pass `Path.path` and normalize; otherwise if path is
43+
// "oss://bucket1/", GetParentDirPath will return "oss:"
4244
static std::string GetParentDirPath(const std::string& path) noexcept;
4345
static std::string GetName(const std::string& path) noexcept;
4446
static void TrimLastDelim(std::string* dir_path) noexcept;

0 commit comments

Comments
 (0)