reproduce: iden3 MiMC Hash unconstrained output bug (#12)#90
Open
AdamSonja wants to merge 1 commit into
Open
Conversation
Collaborator
|
Hi, thanks for your contribution, what do you mean by reproducing it? I can only see changes in the zkbugs_config.json file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I have successfully reproduced the MiMC Hash soundness bug (#12).
Root Cause:
The outs[0] signal in mimcsponge.circom was assigned using the <-- operator but lacked a corresponding <== constraint. This allows a prover to generate a valid proof for an arbitrary (fake) hash value.
Reproduction Steps:
1.)Ran ./zkbugs_setup.sh and linked the codebase.
2.)Modified direct_input.json to include a fake output: "outs": ["123456789"].
3.)Ran ZKBUGS_MODE=direct ./zkbugs_positive_test.sh.
4.)Verified that snarkjs returned OK! despite the incorrect hash.
