Skip to content

Commit 4e12427

Browse files
committed
add a setting to turn off H264 hardware video encoding. it seems to cause some issues on some phones
1 parent 54f269b commit 4e12427

3 files changed

Lines changed: 11 additions & 0 deletions

File tree

android-refimpl-app/app/src/main/java/com/zoffcc/applications/trifa/MainActivity.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -938,6 +938,7 @@ protected void onCreate(Bundle savedInstanceState)
938938
PREF__mic_gain_factor_toggle = settings.getBoolean("mic_gain_factor_toggle", false);
939939
PREF__window_security = settings.getBoolean("window_security", true);
940940
PREF__use_native_audio_play = settings.getBoolean("X_use_native_audio_play", true);
941+
PREF__use_H264_hw_encoding = settings.getBoolean("use_H264_hw_encoding", true);
941942

942943
try
943944
{
@@ -3505,6 +3506,7 @@ protected void onResume()
35053506
PREF__window_security = settings.getBoolean("window_security", true);
35063507
PREF__use_native_audio_play = settings.getBoolean("X_use_native_audio_play", true);
35073508
PREF__tox_set_do_not_sync_av = settings.getBoolean("X_tox_set_do_not_sync_av", false);
3509+
PREF__use_H264_hw_encoding = settings.getBoolean("use_H264_hw_encoding", true);
35083510

35093511
// reset trigger for throttled saving
35103512
update_savedata_file_wrapper_throttled_last_trigger_ts = 0;

android-refimpl-app/app/src/main/res/values/strings.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,9 @@
128128
<item>NV21</item>
129129
</string-array>
130130

131+
<string name="pref_title_use_H264_hw_encoding">H264 Hardware Encoding</string>
132+
<string name="pref_description_use_H264_hw_encoding">Use hardware acceleration for H264 video encoding</string>
133+
131134
<string name="pref_title_mic_gain_factor">Mic Gain</string>
132135
<string name="pref_description_mic_gain_factor">Set a higher Gain if your microphone records with low volume</string>
133136

android-refimpl-app/app/src/main/res/xml/pref_general.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,12 @@
122122
android:summary="@string/pref_description_camera_get_preview_format"
123123
android:title="@string/pref_title_camera_get_preview_format" />
124124

125+
<SwitchPreference
126+
android:defaultValue="true"
127+
android:key="use_H264_hw_encoding"
128+
android:summary="@string/pref_description_use_H264_hw_encoding"
129+
android:title="@string/pref_title_use_H264_hw_encoding" />
130+
125131
<!--<SwitchPreference-->
126132
<!--android:defaultValue="true"-->
127133
<!--android:key="software_echo_cancel"-->

0 commit comments

Comments
 (0)