Skip to content

Commit 0b21772

Browse files
huntiezoontek
authored andcommitted
Fix running all test-all jobs outside PRs (facebook#55917)
Summary: Pull Request resolved: facebook#55917 As a defensive initial design, conditional Android/iOS job runs for `test-all` were intended to be scoped to PRs only, however required a missing `== 'true'` match specifier. Fixing this will help us catch rare integration-conflict failures on `main`, at the appropriate commit. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D95042221 fbshipit-source-id: ffa23651c9b8c18939ccbd7ab2279243690944d2
1 parent 0b65769 commit 0b21772

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/test-all.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ jobs:
3737
runs-on: ubuntu-latest
3838
if: github.repository == 'facebook/react-native'
3939
outputs:
40-
any_code_change: ${{ steps.filter_exclusions.outputs.any_code_change || github.event_name != 'pull_request' }}
41-
should_test_android: ${{ steps.filter_exclusions.outputs.should_test_android || github.event_name != 'pull_request' }}
42-
should_test_ios: ${{ steps.filter_exclusions.outputs.should_test_ios || github.event_name != 'pull_request' }}
40+
any_code_change: ${{ steps.filter_exclusions.outputs.any_code_change == 'true' || github.event_name != 'pull_request' }}
41+
should_test_android: ${{ steps.filter_exclusions.outputs.should_test_android == 'true' || github.event_name != 'pull_request' }}
42+
should_test_ios: ${{ steps.filter_exclusions.outputs.should_test_ios == 'true' || github.event_name != 'pull_request' }}
4343
debugger_shell: ${{ steps.filter_inclusions.outputs.debugger_shell }}
4444
steps:
4545
- name: Checkout

0 commit comments

Comments
 (0)