validate existing type annotations by olamidepeterojo · Pull Request #353 · zowe/zowe-client-python-sdk

olamidepeterojo · 2025-02-11T09:36:53Z

Fixes #321

How to Test

Review Checklist
I certify that I have:

tested my changes
added/updated automated tests
updated the changelog
followed the contribution guidelines

Additional Comments

traeok

Thanks for adding all these types! I had a question about one parameter and a concern about interpreting binary contents.

zFernand0

the overall goal makes sense to me 😋

However, there are a few things that I'm not sure that's exactly they should be done. 😋

Left some comments since I'm not able to run unit (nor integration) tests successfully in this PR 😢

zFernand0

Seems like some items have not been resoled yet.
Please check them out before re-requesting review 🙏

zFernand0 · 2025-03-05T14:56:11Z

Not sure if the re-request is happening automatically because of the force-push 😓
However, I still see a few issues that are not resolved. 😅

For now, I'll remove myself from the list of reviewers on this PR 🙏

olamidepeterojo · 2025-03-05T21:31:39Z

@zFernand0 my apologies. haha, ive been the one re-requesting review. could you please point out the few issues you noticed cause the ones mentioned earlier has been solved

Changes addressed

zFernand0

After fixing these, please run pytest -s tests/unit/ to view any failing unit tests 😅

zFernand0 · 2025-03-06T18:50:53Z

+from .end_response import EndResponse
+from .issue_response import IssueResponse
+from .send_response import SendResponse
+from .start_response import StartResponse


Suggested change

from .end_response import EndResponse

from .issue_response import IssueResponse

from .send_response import SendResponse

from .start_response import StartResponse

from .tso import EndResponse, IssueResponse, SendResponse, StartResponse

zFernand0 · 2025-03-06T18:52:02Z

+from .job_response import JobResponse
+from .spool_response import SpoolResponse
+from .status_response import StatusResponse
+


Suggested change

from .job_response import JobResponse

from .spool_response import SpoolResponse

from .status_response import StatusResponse

from .jobs import JobResponse, SpoolResponse, StatusResponse

zFernand0 · 2025-03-06T18:53:32Z

+from .console_response import ConsoleResponse 
+from .response import IssueCommandResponse


Suggested change

from .console_response import ConsoleResponse

from .response import IssueCommandResponse

from .console import ConsoleResponse, IssueCommandResponse

t1m0thyj · 2025-03-28T15:18:06Z

+### Enhancements
+- Split response classes into individual modules for better maintainability:
+    - `JobResponse` now lives in `job_response.py`
+    - `SpoolResponse` now lives in `spool_response.py`
+    - `StatusResponse` now lives in `status_response.py`
+- Updated imports in relevant modules to reflect these changes.


These enhancements should be moved under a ## Recent Changes header at the top of the CHANGELOG.md file.

t1m0thyj · 2025-03-28T15:18:30Z


 ### Bug Fixes

+- Validate existing type annotations. [#321] (https://github.com/zowe/zowe-client-python-sdk/issues/321)


Similar to previous comment - this bug fix should be moved under a ## Recent Changes header at the top of the CHANGELOG.md file.

t1m0thyj · 2025-03-28T15:22:36Z

Python added a number of built-in types in 3.9 like list and dict. Since we require Python 3.9 or newer, I think we should prefer using these built-in types (lowercase) over ones imported from the typing module (uppercase).

Signed-off-by: Olamide Ojo <peterojoolamide@gmail.com>

olamidepeterojo · 2025-04-16T12:22:51Z

After fixing these, please run pytest -s tests/unit/ to view any failing unit tests 😅

Hello @zFernand0, one major error is:
FAILED tests/unit/core/test_profile_manager.py::TestZosmfProfileManager::test_autodiscovery_and_base_profile_loading - AttributeError: module 'zowe' has no attribute 'secrets_for_zowe_sdk'. Did you mean: 'core_for_zowe_sdk'?. I think this is as a result having no keyring.py file in the secrets_for_zowe_sdk. What do you think about creating a keyring.py file? Kindly advice

zFernand0 · 2025-05-20T16:17:46Z

Hey @olamidepeterojo, 👋
Thanks a lot for the contribution!
We will be moving forward with this PR by placing it into a staging branch.
This will allow us to continue polishing the work while still give you credit for the contribution.
Again, thanks a lot for the invaluable contribution and we hope to continue having you as a Python SDK maintainer 🙏

JTonda requested review from t1m0thyj, traeok and zFernand0 February 19, 2025 16:11

zFernand0 assigned olamidepeterojo Feb 19, 2025

traeok previously requested changes Feb 26, 2025

View reviewed changes

Comment thread src/core/zowe/core_for_zowe_sdk/profile_manager.py Outdated

Comment thread src/zos_files/zowe/zos_files_for_zowe_sdk/uss.py Outdated

olamidepeterojo force-pushed the type_annotation branch from c07cc2b to 4e643a4 Compare February 27, 2025 19:02

olamidepeterojo requested a review from traeok February 27, 2025 19:02

zFernand0 requested changes Mar 3, 2025

View reviewed changes

olamidepeterojo force-pushed the type_annotation branch from 4e643a4 to 9405b81 Compare March 4, 2025 15:45

olamidepeterojo requested a review from zFernand0 March 4, 2025 15:45

zFernand0 requested changes Mar 5, 2025

View reviewed changes

olamidepeterojo force-pushed the type_annotation branch from 9405b81 to ef18862 Compare March 5, 2025 07:36

olamidepeterojo requested a review from zFernand0 March 5, 2025 07:37

zFernand0 removed their request for review March 5, 2025 14:56

zFernand0 requested changes Mar 6, 2025

View reviewed changes

t1m0thyj requested changes Mar 28, 2025

View reviewed changes

zFernand0 moved this from Review/QA to PI Backlog in Zowe CLI Squad Mar 29, 2025

validate existing type annotations

6975821

Signed-off-by: Olamide Ojo <peterojoolamide@gmail.com>

olamidepeterojo force-pushed the type_annotation branch from ef18862 to 6975821 Compare April 16, 2025 11:11

olamidepeterojo requested review from t1m0thyj and zFernand0 April 16, 2025 11:11

olamidepeterojo marked this pull request as draft April 16, 2025 11:11

zowe-robot moved this from PI Backlog to In Progress in Zowe CLI Squad Apr 16, 2025

Merge branch 'main' into type_annotation

81b7c95

zFernand0 changed the base branch from main to staging/353/type_annotation May 20, 2025 16:17

zFernand0 marked this pull request as ready for review May 20, 2025 16:17

zFernand0 merged commit e03211f into zowe:staging/353/type_annotation May 20, 2025
16 of 31 checks passed

github-project-automation Bot moved this from In Progress to Closed in Zowe CLI Squad May 20, 2025

zowe-robot moved this from Closed to Review/QA in Zowe CLI Squad May 20, 2025

zFernand0 moved this from Review/QA to Closed in Zowe CLI Squad May 21, 2025

		from .console_response import ConsoleResponse
		from .response import IssueCommandResponse

	from .console_response import ConsoleResponse
	from .response import IssueCommandResponse
	from .console import ConsoleResponse, IssueCommandResponse


		### Bug Fixes

		- Validate existing type annotations. [#321] (https://github.com/zowe/zowe-client-python-sdk/issues/321)

Uh oh!

Conversation

olamidepeterojo commented Feb 11, 2025

Uh oh!

traeok left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

zFernand0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zFernand0 left a comment

Choose a reason for hiding this comment

Uh oh!

zFernand0 commented Mar 5, 2025

Uh oh!

olamidepeterojo commented Mar 5, 2025

Uh oh!

zFernand0 left a comment

Choose a reason for hiding this comment

Uh oh!

zFernand0 Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

zFernand0 Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

zFernand0 Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

t1m0thyj Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

t1m0thyj Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

t1m0thyj Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

olamidepeterojo commented Apr 16, 2025

Uh oh!

Uh oh!

zFernand0 commented May 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants