Validating Type Annotation by pem70 · Pull Request #365 · zowe/zowe-client-python-sdk

pem70 · 2025-05-27T16:18:26Z

What It Does

#321

How to Test

Review Checklist
I certify that I have:

tested my changes
added/updated automated tests
updated the changelog
followed the contribution guidelines

Additional Comments

Signed-off-by: Olamide Ojo <peterojoolamide@gmail.com>

codecov · 2025-05-27T16:19:12Z

Codecov Report

❌ Patch coverage is 83.13817% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.05%. Comparing base (34b7df9) to head (4bc0833).
⚠️ Report is 29 commits behind head on main.

Files with missing lines	Patch %	Lines
src/core/zowe/core_for_zowe_sdk/config_file.py	68.46%	35 Missing ⚠️
src/core/zowe/core_for_zowe_sdk/profile_manager.py	76.31%	9 Missing ⚠️
.../zos_files/zowe/zos_files_for_zowe_sdk/datasets.py	87.50%	7 Missing ⚠️
src/zos_files/zowe/zos_files_for_zowe_sdk/files.py	86.66%	6 Missing ⚠️
src/core/zowe/core_for_zowe_sdk/zosmf_profile.py	33.33%	4 Missing ⚠️
src/zos_files/zowe/zos_files_for_zowe_sdk/uss.py	76.47%	4 Missing ⚠️
src/zos_jobs/zowe/zos_jobs_for_zowe_sdk/jobs.py	75.00%	2 Missing ⚠️
src/zos_tso/zowe/zos_tso_for_zowe_sdk/tso.py	77.77%	2 Missing ⚠️
tests/unit/files/file_systems/test_file_systems.py	50.00%	2 Missing ⚠️
.../zowe/zos_console_for_zowe_sdk/response/console.py	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   89.09%   88.05%   -1.04%     
==========================================
  Files          65       65              
  Lines        3255     3340      +85     
==========================================
+ Hits         2900     2941      +41     
- Misses        355      399      +44

Flag	Coverage Δ
unittests	`88.05% <83.13%> (-1.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

Also simplify code since most functions factually return None. Signed-off-by: Peizhao Mei <pem70@pitt.edu>

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>

t1m0thyj

Thanks @pem70! Looks good so far, let's discuss with @zFernand0 before making any drastic changes to this PR 🙂

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

traeok

Thanks for working on this Peizhao! My comments are solely based off of a syntactical review, there are a couple nitpicks but mostly requesting changes for the test modifications.

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

Addressed in latest commit

All comments resolved. 😋
Apologies for the delay. 😢

zFernand0

LGTM! 😋

I do have some comments that I would like to either see addressed, or perhaps have a short discussion 🙏

I'm not done reviewing the PR, so there may be more comments incoming 😋

zFernand0

a few more comments 😋

I may have a final round later today 🙏

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

zFernand0

LGTM! 😋

Left some minor comments to address 😅
But I believe the changes are still good to approve 🙏

I'm more than happy to re-review when the new comments are addressed. 🙏

Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>

anaxceron

Left a couple of minor suggestions for the changelog.

Co-authored-by: anaxceron <ana.ceron@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

zFernand0 · 2025-06-18T12:42:16Z

Thanks for the suggestions @anaxceron
We can merge this PR once the checks pass

validate existing type annotations

6975821

Signed-off-by: Olamide Ojo <peterojoolamide@gmail.com>

pem70 requested review from t1m0thyj and zFernand0 May 27, 2025 16:18

github-project-automation Bot added this to Zowe CLI Squad May 27, 2025

github-project-automation Bot moved this to New Issues in Zowe CLI Squad May 27, 2025

zowe-robot moved this from New Issues to In Progress in Zowe CLI Squad May 27, 2025

github-actions Bot assigned pem70 May 27, 2025

pem70 added 10 commits May 27, 2025 12:31

Tempo commit

b090a4e

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

Tempo Commit

0f1a83e

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

Validate type annontation

b5bcfeb

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

Upgrade Dict and List

8b79e4c

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

Validate Type annotation for zos_files

585441d

Also simplify code since most functions factually return None. Signed-off-by: Peizhao Mei <pem70@pitt.edu>

Update for linux building

47369d7

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

Update for workflow

bc130ca

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

Update changelog

00bfdec

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

Update logger.py

2cbc4ec

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

Update logger.py

29eaec4

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

pem70 force-pushed the pr/353-v2 branch from 08be5be to 29eaec4 Compare May 27, 2025 16:37

pem70 requested a review from traeok May 27, 2025 16:39

Merge branch 'main' into pr/353-v2

aa6e067

Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>

pem70 marked this pull request as ready for review May 27, 2025 16:45

zowe-robot moved this from In Progress to Review/QA in Zowe CLI Squad May 27, 2025

t1m0thyj previously requested changes Jun 2, 2025

View reviewed changes

pem70 added 2 commits June 2, 2025 12:28

Change

f13b0e2

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

Update uss.py

9ea4829

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

traeok previously requested changes Jun 3, 2025

View reviewed changes

Resolve formatting issues

d8c839f

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

zFernand0 requested changes Jun 6, 2025

View reviewed changes

zFernand0 reviewed Jun 6, 2025

View reviewed changes

pem70 added 2 commits June 9, 2025 15:51

Resolve comments

3a59571

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

Resolve unit tests

b3679c4

Signed-off-by: Peizhao Mei <pem70@pitt.edu>

pem70 requested a review from zFernand0 June 10, 2025 13:30

Merge branch 'main' into pr/353-v2

50b4406

zFernand0 approved these changes Jun 11, 2025

View reviewed changes

Comment thread CHANGELOG.md Outdated

Comment thread src/core/zowe/core_for_zowe_sdk/config_file.py Outdated

Comment thread CHANGELOG.md Outdated

pem70 and others added 4 commits June 12, 2025 09:53

Update CHANGELOG.md

c7302ce

Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>

Update src/core/zowe/core_for_zowe_sdk/config_file.py

e80ca21

Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>

Update CHANGELOG.md

390dee3

Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Peizhao Mei <105866197+pem70@users.noreply.github.com>

Merge branch 'main' into pr/353-v2

9116db6

JTonda requested review from anaxceron, t1m0thyj and traeok June 16, 2025 15:12

anaxceron reviewed Jun 17, 2025

View reviewed changes

Comment thread CHANGELOG.md Outdated

Comment thread CHANGELOG.md Outdated

zFernand0 and others added 2 commits June 18, 2025 08:41

Update CHANGELOG.md

4480cd9

Co-authored-by: anaxceron <ana.ceron@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

Update CHANGELOG.md

4bc0833

Co-authored-by: anaxceron <ana.ceron@broadcom.com> Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

zFernand0 merged commit 8ee471c into main Jun 18, 2025
22 checks passed

zFernand0 deleted the pr/353-v2 branch June 18, 2025 12:47

github-project-automation Bot moved this from Review/QA to Closed in Zowe CLI Squad Jun 18, 2025

Uh oh!

Conversation

pem70 commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

t1m0thyj left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

traeok left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zFernand0 left a comment

Choose a reason for hiding this comment

LGTM! 😋

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zFernand0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zFernand0 left a comment

Choose a reason for hiding this comment

LGTM! 😋

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anaxceron left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

zFernand0 commented Jun 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pem70 commented May 27, 2025 •

edited

Loading

codecov Bot commented May 27, 2025 •

edited

Loading

t1m0thyj left a comment •

edited

Loading