Skip to content

chore: fix pydoclint warnings 😋#400

Merged
t1m0thyj merged 3 commits into
mainfrom
fix-lint
Jun 24, 2026
Merged

chore: fix pydoclint warnings 😋#400
t1m0thyj merged 3 commits into
mainfrom
fix-lint

Conversation

@zFernand0

Copy link
Copy Markdown
Member

What It Does

Address all warnings in pydoclint

How to Test

pydoclint --exclude=".*/(build|response)/.*" src

Review Checklist
I certify that I have:

Additional Comments

Excluded build|response in the pyproject.toml to align with CI 🙏

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
@zFernand0 zFernand0 requested a review from t1m0thyj June 19, 2026 12:49
@github-project-automation github-project-automation Bot moved this to New Issues in Zowe CLI Squad Jun 19, 2026
@zowe-robot zowe-robot moved this from New Issues to Review/QA in Zowe CLI Squad Jun 19, 2026
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.13%. Comparing base (24102f6) to head (6e57872).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   82.13%   82.13%           
=======================================
  Files          49       49           
  Lines        2916     2916           
=======================================
  Hits         2395     2395           
  Misses        521      521           
Flag Coverage Δ
unittests 82.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

@t1m0thyj t1m0thyj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zFernand0!

Comment thread pyproject.toml
check-arg-order = false
require-return-section-when-returning-nothing = false
quiet = true
exclude = "build|response"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious what build refers to here, but makes sense we want to exclude response dataclasses 😋

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 that's a good question.
I guess I just tried following CI without giving it much thought 😢
https://github.com/zowe/zowe-client-python-sdk/blob/main/.github/workflows/sdk-build.yml#L37

I'll look into it 😋

@t1m0thyj t1m0thyj merged commit 3bd6749 into main Jun 24, 2026
21 checks passed
@t1m0thyj t1m0thyj deleted the fix-lint branch June 24, 2026 04:53
@github-project-automation github-project-automation Bot moved this from Review/QA to Closed in Zowe CLI Squad Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants