Skip to content

support for configs in jsonc or json#54

Open
mrhut10 wants to merge 1 commit intozpg6:mainfrom
mrhut10:feat/support-wrangler-config-formats
Open

support for configs in jsonc or json#54
mrhut10 wants to merge 1 commit intozpg6:mainfrom
mrhut10:feat/support-wrangler-config-formats

Conversation

@mrhut10
Copy link
Copy Markdown

@mrhut10 mrhut10 commented Apr 22, 2026

hoping this allows the CLI to work with other config file types. as identified in
#20 and in #53 I believe

@zpg6
Copy link
Copy Markdown
Owner

zpg6 commented Apr 22, 2026

Hi @mrhut10, thanks for contributing this! I'll test and merge in the next few days.

@mrhut10
Copy link
Copy Markdown
Author

mrhut10 commented Apr 22, 2026

cheers @zpg6 look forward to the feedback,
appeared to be working for me locally with my .jsonc config but i didn't attempt to test .toml or .json directly other than the unit tests so would be good to test that e2e as well.

let me know if can help any more

@zpg6
Copy link
Copy Markdown
Owner

zpg6 commented Apr 22, 2026

@mrhut10 If you can conduct e2e testing, even exploratory and leave me a few notes, that would speed us along :)

@mrhut10 mrhut10 mentioned this pull request Apr 23, 2026
@mrhut10
Copy link
Copy Markdown
Author

mrhut10 commented Apr 23, 2026

@mrhut10 If you can conduct e2e testing, even exploratory and leave me a few notes, that would speed us along :)

yep test evidence.

CLI under test: @better-auth-cloudflare/cli@0.1.19 at commit b320c38, consumed via file:../better-auth-cloudflare.

done via a worktree for each configs wrangler.jsonc | wrangler.json | wrangler.toml

Check wrangler.jsonc wrangler.json wrangler.toml
migrate --migrate-target=skip (auto-detect, parse, run auth:update + db:generate)
migrate --migrate-target=dev (full flow + wrangler d1 migrations apply --local)
migrate --migrate-target=skip --config=./custom.<ext> (explicit path override with non-default filename)

let me know if anything else needs testing with it

@mrhut10
Copy link
Copy Markdown
Author

mrhut10 commented Apr 29, 2026

Have you had a chance to review @zpg6 ?

@zpg6
Copy link
Copy Markdown
Owner

zpg6 commented Apr 29, 2026

Have you had a chance to review @zpg6 ?

Hi @mrhut10, sorry for delay still finding time to review your great work here. Thanks

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 5, 2026

Open in StackBlitz

npm i https://pkg.pr.new/better-auth-cloudflare@54

commit: b320c38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants