[codex] Fix Google Photos Picker discovery#3
Draft
zrm625 wants to merge 2 commits into
Draft
Conversation
cc1d167 to
38a17ed
Compare
Owner
Author
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
00e9ed3 to
cc930b9
Compare
cc930b9 to
e91270a
Compare
d2a0e7d to
3ff0a97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Google APIs whose live Discovery documents only work at their service-hosted URL. This covers Google Photos Picker, Forms, and Keep. Also show required OAuth scopes in the generic OAuth app registration form.
Bug
I added Google Photos Picker support and the Picker bug in the same PR, so there was never a known-good upstream Picker path.
Picker's live Discovery URL is
https://photospicker.googleapis.com/$discovery/rest?version=v1; the rewritten central URL returns 404. Its live document also omits OAuth scope metadata, so Picker could be added without the requiredhttps://www.googleapis.com/auth/photospicker.mediaitems.readonlyscope.The test fixture missed this because it was more complete than Google's live document. While validating the deployed fix, the default Google bundle exposed the same service-hosted-only Discovery issue for Forms and Keep.
Introduced in: RhysSullivan#1137
Related normalizer change: RhysSullivan#1106
Fix
The UI change is disclosure-only. It does not request new permissions.
Screenshot
Validation
bun run --cwd packages/plugins/google test -- src/sdk/discovery.test.ts src/sdk/plugin.test.tsbun run --cwd packages/react test -- src/components/oauth-client-form.test.tsexecutor v1.5.23:/returns 200 and/mcpreturns unauthenticated 401.