revert: remove debug timing instrumentation from video write loop

Author: zsiec

distribution/moq_session.go

@@ -500,9 +500,6 @@ func (m *MoQSession) Stats() ViewerStats {
 func (m *MoQSession) writeVideoLoop(ctx context.Context, sub *moqTrackSub) {
 	var currentStream *webtransport.SendStream
 	var currentGroupID uint32
-	var streamOpenTotal, frameWriteTotal time.Duration
-	var streamOpenCount, frameWriteCount int64
-	var maxStreamOpen, maxFrameWrite time.Duration
 
 	closeStream := func() {
 		if currentStream != nil {
@@ -512,35 +509,10 @@ func (m *MoQSession) writeVideoLoop(ctx context.Context, sub *moqTrackSub) {
 	}
 	defer closeStream()
 
-	// Periodic logging of write timing stats.
-	logTicker := time.NewTicker(10 * time.Second)
-	defer logTicker.Stop()
-
 	for {
 		select {
 		case <-ctx.Done():
 			return
-		case <-logTicker.C:
-			qLen := len(sub.videoCh)
-			var avgOpen, avgWrite float64
-			if streamOpenCount > 0 {
-				avgOpen = float64(streamOpenTotal.Microseconds()) / float64(streamOpenCount)
-			}
-			if frameWriteCount > 0 {
-				avgWrite = float64(frameWriteTotal.Microseconds()) / float64(frameWriteCount)
-			}
-			m.log.Info("video write loop stats",
-				"queue_len", qLen,
-				"queue_cap", cap(sub.videoCh),
-				"stream_opens", streamOpenCount,
-				"avg_open_us", avgOpen,
-				"max_open_us", maxStreamOpen.Microseconds(),
-				"frame_writes", frameWriteCount,
-				"avg_write_us", avgWrite,
-				"max_write_us", maxFrameWrite.Microseconds(),
-				"video_sent", m.videoSent.Load(),
-				"video_dropped", m.videoDropped.Load(),
-			)
 		case frame, ok := <-sub.videoCh:
 			if !ok {
 				return
@@ -550,21 +522,7 @@ func (m *MoQSession) writeVideoLoop(ctx context.Context, sub *moqTrackSub) {
 				closeStream()
 				currentGroupID = frame.GroupID
 
-				t0 := time.Now()
 				stream, err := m.session.OpenUniStreamSync(ctx)
-				dt := time.Since(t0)
-				streamOpenTotal += dt
-				streamOpenCount++
-				if dt > maxStreamOpen {
-					maxStreamOpen = dt
-				}
-				if dt > 50*time.Millisecond {
-					m.log.Warn("slow stream open",
-						"duration_ms", dt.Milliseconds(),
-						"queue_len", len(sub.videoCh),
-					)
-				}
-
 				if err != nil {
 					m.log.Debug("video stream open failed", "error", err)
 					return
@@ -583,23 +541,7 @@ func (m *MoQSession) writeVideoLoop(ctx context.Context, sub *moqTrackSub) {
 				continue
 			}
 
-			t0 := time.Now()
 			n, err := sub.writer.WriteVideoFrame(currentStream, frame)
-			dt := time.Since(t0)
-			frameWriteTotal += dt
-			frameWriteCount++
-			if dt > maxFrameWrite {
-				maxFrameWrite = dt
-			}
-			if dt > 50*time.Millisecond {
-				m.log.Warn("slow frame write",
-					"duration_ms", dt.Milliseconds(),
-					"frame_size", len(frame.WireData),
-					"keyframe", frame.IsKeyframe,
-					"queue_len", len(sub.videoCh),
-				)
-			}
-
 			if err != nil {
 				closeStream()
 				m.log.Debug("video frame write failed", "error", err)