[codex] Fix no-variable operations with provided variables (#622)

* Add provided variable mutation repro

* Normalize operation variables before Relay calls

* Add changelog entry for provided variable fix

Author: zth

CHANGELOG.md

@@ -1,5 +1,7 @@
 # master
 
+- Fix operations with no user supplied variables crashing when they include provided variables.
+
 # 4.4.1
 
 - Change name on internal fetch fn to avoid accidental shadowing.

packages/rescript-relay/__tests__/Test_mutation-tests.js

@@ -159,6 +159,47 @@ describe("Mutation", () => {
     await t.screen.findByText("First is idle");
   });
 
+  test("mutation with no variables can spread a provided variable fragment", async () => {
+    queryMock.mockQuery({
+      name: "TestMutationQuery",
+      data: {
+        loggedInUser: {
+          id: "user-1",
+          firstName: "First",
+          lastName: "Name",
+          onlineStatus: "Online",
+          memberOf,
+        },
+      },
+    });
+
+    t.render(test_mutation());
+    await t.screen.findByText("Provided variable mutation status: -");
+
+    queryMock.mockQuery({
+      name: "TestMutationWithProvidedVariableFragmentMutation",
+      variables: {
+        __relay_internal__pv__ProvidedVariablesBool: true,
+      },
+      data: {
+        updateUserAvatar: {
+          user: {
+            id: "user-1",
+            someRandomArgField: "provided variable value",
+          },
+        },
+      },
+    });
+
+    ReactTestUtils.act(() => {
+      t.fireEvent.click(
+        t.screen.getByText("Run mutation with provided variable fragment")
+      );
+    });
+
+    await t.screen.findByText("Provided variable mutation status: completed");
+  });
+
   test("optimistic response works", async () => {
     queryMock.mockQuery({
       name: "TestMutationQuery",

packages/rescript-relay/__tests__/Test_mutation.res

@@ -29,6 +29,16 @@ module ComplexMutation = %relay(`
     }
 `)
 
+module MutationWithProvidedVariableFragment = %relay(`
+    mutation TestMutationWithProvidedVariableFragmentMutation {
+      updateUserAvatar {
+        user {
+          ...TestMutationProvidedVariable_user
+        }
+      }
+    }
+`)
+
 module MutationWithOnlyFragment = %relay(`
     mutation TestMutationWithOnlyFragmentSetOnlineStatusMutation($onlineStatus: OnlineStatus!) @raw_response_type {
       setOnlineStatus(onlineStatus: $onlineStatus) {
@@ -57,6 +67,15 @@ module Fragment = %relay(`
     }
 `)
 
+module ProvidedVariableFragment = %relay(`
+    fragment TestMutationProvidedVariable_user on User
+      @argumentDefinitions(
+        bool: { type: "Boolean!", provider: "ProvidedVariables.Bool" }
+      ) {
+      someRandomArgField(bool: $bool)
+    }
+`)
+
 module MutationWithInlineFragment = %relay(`
     mutation TestMutationWithInlineFragmentSetOnlineStatusMutation($onlineStatus: OnlineStatus!) @raw_response_type {
       setOnlineStatus(onlineStatus: $onlineStatus) {
@@ -84,6 +103,9 @@ module Test = {
     let data = Fragment.use(query.loggedInUser.fragmentRefs)
     let (mutate, isMutating) = Mutation.use()
     let (inlineStatus, setInlineStatus) = React.useState(_ => "-")
+    let (providedVariableMutationStatus, setProvidedVariableMutationStatus) = React.useState(_ =>
+      "-"
+    )
     let someJsonValue =
       [
         ("foo", JSON.Encode.null),
@@ -114,6 +136,11 @@ module Test = {
         }),
       )}
       <div> {React.string("Inline status: " ++ inlineStatus)} </div>
+      <div>
+        {React.string(
+          "Provided variable mutation status: " ++ providedVariableMutationStatus,
+        )}
+      </div>
       <button
         onClick={_ => {
           let _ = {
@@ -215,6 +242,20 @@ module Test = {
       >
         {React.string("Change online status, complex")}
       </button>
+      <button
+        onClick={_ => {
+          open MutationWithProvidedVariableFragment
+          commitMutation(~environment, ~variables=(), ~onCompleted=(response, _) => {
+            switch response {
+            | {updateUserAvatar: Some({user: Some(_)})} =>
+              setProvidedVariableMutationStatus(_ => "completed")
+            | _ => setProvidedVariableMutationStatus(_ => "missing user")
+            }
+          })->RescriptRelay.Disposable.ignore
+        }}
+      >
+        {React.string("Run mutation with provided variable fragment")}
+      </button>
       <button
         onClick={_ => {
           let _ = {