use optional fields for refetch variables#588
Merged
Conversation
Owner
|
This is great! But, if we're to merge this, I would really really like the test suite for refetch variables to be extended thoroughly to handle all relevant cases for how refetch variables is supposed to behave. Here's the relevant docs section: https://relay.dev/docs/next/api-reference/use-refetchable-fragment/#return-value |
tsnobip
force-pushed
the
revamp-refetch-variables
branch
3 times, most recently
from
December 7, 2025 15:52
a91c6da to
1b35023
Compare
tsnobip
force-pushed
the
revamp-refetch-variables
branch
from
December 8, 2025 07:57
1b35023 to
49af8ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, untouched optional variables were set as null instead of not being defined. This is now fixed.
To be used with zth/relay#32