[codex] Fix no-variable operations with provided variables#622
Merged
Conversation
zth
marked this pull request as ready for review
May 20, 2026 08:28
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a regression test for a mutation that has no user-supplied variables but spreads a fragment with a Relay provided variable, then fixes the crash by normalizing converted operation variables before they are handed to Relay.
Root Cause
For operations whose variables type is
unit, ReScript emits JavaScriptundefined. Relay expects operation variables to be an object and reads fromvariables[def.name]before applyingparams.providedVariables, so a no-variable mutation with only provided variables crashes while creating the operation descriptor.Changes
internal_cleanObjectFromUndefinedRawbefore Relay calls.Validation
yarn buildyarn test --runTestsByPath __tests__/Test_mutation-tests.js --runInBandyarn test:ci