Fix useRefetchable/fromData incompatibility#634
Open
benjamin-thomas wants to merge 4 commits into
Open
Conversation
tsnobip
requested changes
Jun 8, 2026
Collaborator
There was a problem hiding this comment.
great fix @benjamin-thomas!
I'd just avoid using @obj and don't forget to update the CHANGELOG.md (add a # master section on top)
Co-authored-by: Paul Tsnobiladzé <paul.tsnobiladze@gmail.com>
fd9fe3a to
bb5d095
Compare
Author
|
Just a heads up, I added another commit to handle the pagination hook. Let's say you want to demonstrate a component that requires pagination, this resulted in a runtime error. I applied the same solution as before : detect if we have test data from There's probably at least one or a few hooks that could receive the same treatment but I'm only concerned with those two at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
#628 introduced
fromData, but it appeared to be incompatible with theuseRefetchableFragmenthook.This change short-circuits the hook, similar to what was done in
useFragmentalready.For the background info: I encountered this error while trying to render some components on a "storybook-like" page.
The runtime error looked something like this:
The failing test captures the error I encountered faithfully