fix remove-unused-fields command#636
Merged
Merged
Conversation
- make it use rescript-tools from the installed rescript package instead of relying on the outdated @rescript/tools package - get the artifact directory from relay config - do not analyze files in relay config `excludes`
Owner
|
Excellent stuff! Any more tests worth adding? If not, a changelog please and then we should be good to go. |
tsnobip
force-pushed
the
fix-remove-unused-fields
branch
from
ba933fc to
334ef25
Compare
Collaborator
Author
|
@zth I'll try to come up with a nice E2E test to avoid this to happen again. |
Collaborator
Author
|
@zth done! |
tsnobip
force-pushed
the
fix-remove-unused-fields
branch
from
cc9f72f to
7b882af
Compare
tsnobip
force-pushed
the
fix-remove-unused-fields
branch
from
7b882af to
53ab675
Compare
zth
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
excludes