Add docs, error handling for my rushed work from 2 years ago#8
Merged
Merged
Conversation
Member
|
This looks great, thank you. I think that the docs need to be regenerated manually, but I'll do that as soon as I package + release the new version of circuitsim-tester just to avoid clogging up the commit history |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like I did a pretty messy job in ausbin#3, so add a lot of Javadoc that I should've added already. Making a PR into this repository instead of tormenting TAs by asking y'all to merge work between two now-diverged repositories
I don't know how Javadoc is generated in this repository. Should I go ahead and regenerate it? I'm on Java 14 and the diff was gargantuan (current Javadoc looks to be generated with Java 11) so I held off