Implement dark mode using win32-darkmodelib

[lostindark]

Vendor ozone10/win32-darkmodelib source files directly in darkmodelib/ to provide native Windows dark mode support for Notepad4's UI chrome, tied to the existing Style Theme (Default/Dark) setting.

Features:

• Dark title bar, menu bar, context menus (via system dark mode APIs)
• Dark toolbar, rebar, status bar with darkmodelib subclassing
• Dark tooltips and scrollbars
• All dialogs automatically themed via WH_CALLWNDPROCRET hook on WM_INITDIALOG (no per-dialog-proc changes needed)
• Toolbar Customize dialog fixed with temporary SetSysColors override
• Custom color hierarchy for visual depth: Editor #1E1E1E / Dialogs #252526 / Toolbar #2D2D2D / Controls #383838
• View colors for list boxes, list views, tree views, and headers
• Theme switching via View > Style Theme toggles dark mode on/off
• WM_SETTINGCHANGE handled for system dark/light mode changes

[zufuliu]

Please wait a bit, looks win32-darkmodelib has too many codes (main branch 1M lines, old win32-darkmode only has hundred lines).

D:\Libs\win32-darkmodelib\src>perl d:\Dev\MSYS2\opt\bin\cloc.pl .
      27 text files.
      27 unique files.
       0 files ignored.

github.com/AlDanial/cloc v 2.08  T=0.08 s (322.6 files/s, 164987.9 lines/s)
---------------------------------------------------------------------------------------
Language                             files          blank        comment           code
---------------------------------------------------------------------------------------
C++                                     10           1264           3192           6641
C/C++ Header                            15            366            589           1532
Windows Module Definition                1              0              0            183
Windows Resource File                    1              2              4             34
---------------------------------------------------------------------------------------
SUM:                                    27           1632           3785           8390
---------------------------------------------------------------------------------------

I don't understand why it's need to subcalss all common controls.

[lostindark]

Please wait a bit, looks win32-darkmodelib has too many codes (main branch 1M lines, old win32-darkmode only has hundred lines).

D:\Libs\win32-darkmodelib\src>perl d:\Dev\MSYS2\opt\bin\cloc.pl .
      27 text files.
      27 unique files.
       0 files ignored.

github.com/AlDanial/cloc v 2.08  T=0.08 s (322.6 files/s, 164987.9 lines/s)
---------------------------------------------------------------------------------------
Language                             files          blank        comment           code
---------------------------------------------------------------------------------------
C++                                     10           1264           3192           6641
C/C++ Header                            15            366            589           1532
Windows Module Definition                1              0              0            183
Windows Resource File                    1              2              4             34
---------------------------------------------------------------------------------------
SUM:                                    27           1632           3785           8390
---------------------------------------------------------------------------------------

I don't understand why it's need to subcalss all common controls.

Isn't the code 8k lines?

Those common controls won't render correctly in dark mode. Some part of the control will still rendering the way in light theme. E.g. buttons render as light, or some background render as light.

I didn't find a simple way to fix them without subclass them. In fact notepad++ also does the same way (subclass those controls).

[zufuliu]

Isn't the code 8k lines?

It matters at least for matepath:

D:\notepad4\notepad4\matepath\src>perl d:\Dev\MSYS2\opt\bin\cloc.pl .
      20 text files.
      18 unique files.
       2 files ignored.

github.com/AlDanial/cloc v 2.08  T=0.09 s (200.3 files/s, 132208.7 lines/s)
-----------------------------------------------------------------------------------
Language                         files          blank        comment           code
-----------------------------------------------------------------------------------
C++                                  5           1343           1129           7268
C/C++ Header                        10            174            213           1090
Windows Resource File                1             58             61            540
DOS Batch                            2              0              0              6
-----------------------------------------------------------------------------------
SUM:                                18           1575           1403           8904
-----------------------------------------------------------------------------------

[lostindark]

Isn't the code 8k lines?

It matters at least for matepath:

D:\notepad4\notepad4\matepath\src>perl d:\Dev\MSYS2\opt\bin\cloc.pl .
      20 text files.
      18 unique files.
       2 files ignored.

github.com/AlDanial/cloc v 2.08  T=0.09 s (200.3 files/s, 132208.7 lines/s)
-----------------------------------------------------------------------------------
Language                         files          blank        comment           code
-----------------------------------------------------------------------------------
C++                                  5           1343           1129           7268
C/C++ Header                        10            174            213           1090
Windows Resource File                1             58             61            540
DOS Batch                            2              0              0              6
-----------------------------------------------------------------------------------
SUM:                                18           1575           1403           8904
-----------------------------------------------------------------------------------

matepath is a different project right? Haven't looked into support darkmode on it yet.

[Matteo-Nigro]

This is a long overdue feature, it would be nice to be able to implement it. 💪🏻
If with the Dark mod of the toolbar the icons are unclear let me know and I will update them or review them 🖌️

[Casonctin]

After testing, I found that the scroll bar is white and the save changes dialog.

[lostindark]

After testing, I found that the scroll bar is white and the save changes dialog.

This should be fixed now.

[Casonctin]

After testing, I found that the scroll bar is white and the save changes dialog.

This should be fixed now.

Confirmed its fixed. Every dialog and popup is now in dark mode! Thank you!

[Matteo-Nigro]

Great job, @lostindark it looks really nice now. Well done!
Just a quick note: the toolbars' button rollovers still use the old (light) style.
Unlike the menu bar, which uses the dark style for its rollovers.

[lostindark]

Great job, @lostindark it looks really nice now. Well done! Just a quick note: the toolbars' button rollovers still use the old (light) style. Unlike the menu bar, which uses the dark style for its rollovers.

Fixed in latest commit.

[zufuliu]

Appearance for default theme is not good and doesn't match system default (looks old classic theme):

Above is old system default (white background for menubar and toolbar), below is new (grey background for menubar and toolbar).

This change increase exe size by 93KB, I think we needs some custom/samll version of darkmodelib, at least bugprone-exception-escape warnings needs to be fixed (e.g. by not use C++ STL).

[lostindark]

Appearance for default theme is not good and doesn't match system default (looks old classic theme): Above is old system default (white background for menubar and toolbar), below is new (grey background for menubar and toolbar).

This change increase exe size by 93KB, I think we needs some custom/samll version of darkmodelib, at least bugprone-exception-escape warnings needs to be fixed (e.g. by not use C++ STL).

Both issues fixed. Though the smaller version of darmodelib might be tricky.

[lostindark]

Rework the integration, so the change is a bit easier to read.

[Casonctin]

To be honest, the old menu color looked better. There's now a space between the menu and the toolbar.

[zufuliu]

smaller version of darmodelib might be tricky.

I'm still prefer custom smaller version:

1. DPI related functions already loaded by Scintilla_LoadDpiForWindow().
2. cast FAPROC to target function with reinterpret_cast is poor, DLLFunction (__builtin_bit_cast) can be used.
3. using C++ STL in Win32 callback without try/catch, the code can be changed to use local buffer.

deferred this to next release, I need some time to fix Markdown lexer crashes.

[zufuliu]

Here needs further tuning:

1. backgroud color for readonly edit box.
2. size grip (scrollbar at right bottom) is missing on statusbar, and has a rect on dialog.
3. open dark custom schemes dialog is slower than current.
4. some dialog has custom WM_CTLCOLORSTATIC.

[zufuliu]

Thanks for the tweaks, I think we may need to implement our own MessageBox instead of using TaskDialog:

It has same appearance as our InfoBox, which I think it can be reused, handling extra MB_YESNOCANCEL button and hide the checkbox is easy, the hard part is dynamic resize message content (IDC_INFOBOXRECT and IDC_INFOBOXTEXT).

[zufuliu]

I think we may need to implement our own MessageBox instead of using TaskDialog:

[zufuliu]

Here is possibly a simple way to fix back color for system MessageBox:

case WM_CTLCOLORSTATIC: {
	HDC hdc = AsPointer<HDC>(wParam);
	SetBkMode(hdc, TRANSPARENT);
	return AsInteger<LONG_PTR>(GetSysColorBrush(COLOR_3DFACE));	
}
case WM_PAINT: {
	PAINTSTRUCT ps{};
	HDC hdc = BeginPaint(hwnd, &ps);
	RECT rc = {0, 26, 0, 25};
	MapDialogRect(hwnd, &rc);
	const int bottom = rc.top; // TODO: figure out bottom height
	printf("bottom: 26 => %d, 25 => %d\n", bottom, rc.bottom);
	rc = ps.rcPaint;
	rc.bottom -= bottom;
	::FillRect(hdc, &rc, GetSysColorBrush(COLOR_3DFACE));
	rc.top = rc.bottom;
	rc.bottom += bottom;
	::FillRect(hdc, &rc, GetSysColorBrush(COLOR_HIGHLIGHT));
	EndPaint(hwnd, &ps);
	return 0;			
}

the bottom height is 25 for our InfoBox template (74 - 49), seems is 26 for MessageBox, needs to test on Hi-DPI monitor (2K or more) and different system language/locale.

[zufuliu]

Using SetWindowsHookEx() will make application slow, it has impact on startup speed (enable log inside InitInstance()). an alternative approach I think is just setup dark dialog at end of WM_INITDIALOG (e.g. replace CenterDlgInParent() with DarkMode_ApplyToDialog()).

[zufuliu]

const bool hasSizeGrip = !IsZoomed(hwndMain); can be used to check size grip on statusbar, no need to change its style.

[zufuliu]

Customize toolbar dialog can be changed to handle TBN_BEGINADJUST and TBN_ENDADJUST, which could also catch the dialog when double click on toolbar's whitespace area, e.g.:

case IDC_TOOLBAR:
	switch (pnmh->code) {
	case TBN_BEGINADJUST:
		DialogHook_Start(DialogRefData_CustomizeToolbar);
		break;
	case TBN_ENDADJUST:
		DialogHook_Stop();
		UpdateToolbar();
		break;