Skip to content

Security: Client-side-only authorization filtering for menu/routes #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tuanaiseo wants to merge 1 commit into
base: master
Choose a base branch
from
+35 −11
Open

Security: Client-side-only authorization filtering for menu/routes #1167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 35 additions & 11 deletions src/layouts/PrimaryLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,16 @@ export default function PrimaryLayout({
const [menus, setMenus] = useState<MenuItem[] | null>(null);
const [routesDb, setRoutesDb] = useState<RouteEntry[] | null>(null);

const permissionPaths = useMemo(() => {
const permsRaw: Admin['permissions'] | null =
(currentAdmin && currentAdmin.permissions) || null;
if (typeof permsRaw !== 'string') return [];
return permsRaw
.split(',')
.map((s: string) => s.trim())
.filter(Boolean);
}, [currentAdmin]);

useEffect(() => {
const v = localStorage.getItem('app-sider-collapsed');
if (v !== null) setCollapsed(v === 'true');
Expand Down Expand Up @@ -118,21 +128,35 @@ export default function PrimaryLayout({
})();
}, [isMounted]);

const filteredMenu = useMemo(() => {
// normalize currentAdmin.permissions to an array of paths or '*' string
const permsRaw: Admin['permissions'] | null =
(currentAdmin && currentAdmin.permissions) || null;
let perms: string[] = [];
if (typeof permsRaw === 'string') {
perms = permsRaw
.split(',')
.map((s: string) => s.trim())
.filter(Boolean);
useEffect(() => {
if (!currentAdmin) return;
if (!permissionPaths.length || permissionPaths.includes('*')) return;

const currentPath = pathname.replace(/\/+$/, '') || '/';
const allowed = permissionPaths.some((p: string) => {
const permPath = p.replace(/\/+$/, '') || '/';
return currentPath === permPath || currentPath.startsWith(`${permPath}/`);
});

if (allowed) return;

if (!WARNED_PATHS.has(pathname)) {
WARNED_PATHS.add(pathname);
message.warning('You do not have permission to access this page');
}

const fallback = permissionPaths[0] || '/';
if (pathname !== fallback) {
history.replace(fallback);
}
}, [currentAdmin, pathname, permissionPaths]);

const filteredMenu = useMemo(() => {
const perms = permissionPaths;

const isAllowed = (item: FrontendMenu): boolean => {
// if no permissions configured for this user, deny access to guarded items
if (!perms || !perms.length) return false;
if (perms.includes('*')) return true;
if (item.path && perms.includes(item.path)) return true;
// also allow matching by menu key (e.g. perms may contain '/dashboard' while item.path is '/')
if (item.key && perms.includes('/' + String(item.key))) return true;
Expand Down