integrations: Remove deprecated !avatar syntax from git integration#912
Open
taylornlane wants to merge 1 commit intozulip:mainfrom
Open
integrations: Remove deprecated !avatar syntax from git integration#912taylornlane wants to merge 1 commit intozulip:mainfrom
taylornlane wants to merge 1 commit intozulip:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #632
The
!avatar()markdown syntax was removed from Zulip some time ago, but was still being used in the git integration. This commit replaces all remaining uses with plain text formatting.Changes:
zulip/integrations/git/post-receive: updated default fallback commit formatzulip/integrations/git/zulip_git_config.py: updated the activeformat_commit_message()function and the commented exampleHow did you test this PR?
Ran the existing test suite (
pytest zulip_bots/) and confirmed all 42 tests pass. Verified no remaining!avatarreferences exist in source files using grep.Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: