Skip to content

Fix flake build, enum query params, and CI#3

Merged
zupo merged 1 commit into
mainfrom
fix/build
Mar 26, 2026
Merged

Fix flake build, enum query params, and CI#3
zupo merged 1 commit into
mainfrom
fix/build

Conversation

@dz0ny

@dz0ny dz0ny commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings March 26, 2026 08:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves reliability of enum handling during Elm SDK generation and makes the project easier to build/test consistently in CI and via Nix flakes.

Changes:

  • Fix named-enum lookup to be order-insensitive by sorting enum variant keys before dictionary lookup.
  • Add a regression test ensuring named enum query params use enum-to-string helpers even when enum variant order differs.
  • Update build tooling: introduce a Nix flake-based build (with Elm dep pinning artifacts), adjust Volta’s Node pin, and expand CI triggers.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/Test/OpenApi/Generate.elm Adds regression test for enum query params + new expectOccurrenceCount helper.
src/CliMonad.elm Sorts enum variants before lookup to match how enums are keyed during extraction.
package.json Updates Volta pinned Node version.
flake.nix Reworks flake to build the CLI with Bun + Elm deps via fetchElmDeps, and exposes packages/apps.
cli/registry.dat Adds Elm package registry data needed for reproducible Elm dependency fetching in Nix.
cli/elm-srcs.nix Adds pinned Elm dependency sources/hashes for Nix builds.
.gitignore Ignores result symlink from nix build.
.github/workflows/ci.yaml Runs CI on pushes to main in addition to PRs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/Test/OpenApi/Generate.elm
Repository owner deleted a comment from github-actions Bot Mar 26, 2026
Repository owner deleted a comment from github-actions Bot Mar 26, 2026
Repository owner deleted a comment from github-actions Bot Mar 26, 2026
@zupo zupo merged commit 6b94745 into main Mar 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants