Skip to content

Migrated to Python 3 and fixed a bug in xgb defs#2

Open
kdubovikov wants to merge 3 commits into
zygmuntz:masterfrom
kdubovikov:master
Open

Migrated to Python 3 and fixed a bug in xgb defs#2
kdubovikov wants to merge 3 commits into
zygmuntz:masterfrom
kdubovikov:master

Conversation

@kdubovikov
Copy link
Copy Markdown

Hi, I have migrated the codebase to Python 3 and fixed a bug in defs/xgb.py. Hope this will be useful

@zygmuntz
Copy link
Copy Markdown
Owner

Thanks, but it won't work with Python 2 now, will it?

@kdubovikov
Copy link
Copy Markdown
Author

kdubovikov commented Jun 25, 2017

Yes, you are right. I will manage this with from __future__ import print_function and update the PR. Then it will work with Python 2 and 3 simultaneously

UPDATE please see new commit, you may check if it works with Python 2 now

@zygmuntz
Copy link
Copy Markdown
Owner

zygmuntz commented Jun 28, 2017

You haven't updated all the prints in defs/* and defs_regression/*, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants