Skip to content

Commit e2ad744

Browse files
authored
test: remove test-node-output-v8-warning
asm.js validation is deprecated and disabled by default in V8, so there's no longer a stable user-reachable trigger for `v8::Isolate::kMessageWarning`. Remove the test. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: nodejs#63469 Fixes: nodejs/node-v8#310 Refs: https://issues.chromium.org/issues/510487707 Refs: nodejs#24365 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent b9203ee commit e2ad744

3 files changed

Lines changed: 0 additions & 36 deletions

File tree

test/fixtures/v8/v8_warning.js

Lines changed: 0 additions & 19 deletions
This file was deleted.

test/fixtures/v8/v8_warning.snapshot

Lines changed: 0 additions & 2 deletions
This file was deleted.

test/parallel/test-node-output-v8-warning.mjs

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)