[pull] main from nodejs:main#93
Merged
Merged
Conversation
I missed marking a couple of test cases flaky in my previous PR: #58583 tests missed were: - parallel.test-inspector-network-content-type - benchmark.test-benchmark-websocket After marking the above flaky I re-ran a test build and noticed the build still failed. Unfortuantely the build still fails because the build detects that node process are left behind after the tests, presumably because tests that spawn child processes are being timed out and only the parent process is killed off, leaving the child processes behind. see: #59014 (comment) We've decided to skip these tests until the underlying issue is resolved. The tests being skipped are: - parallel.test-http-proxy-fetch - parallel.test-https-proxy-fetch - benchmark.test-benchmark-websocket - parallel.test-inspector-network-fetch - parallel.test-inspector-network-content-type - es-module.test-wasm-web-api - parallel.test-fetch - parallel.test-without-async-context-frame - report.test-report-exclude-network PR-URL: #59014 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #59086 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )