Fix some sonarcloud issues (#971)

* Fix some sonarcloud issues

* .

* array

Author: StefH

src/System.Linq.Dynamic.Core.NewtonsoftJson/Extensions/JObjectExtensions.cs

@@ -11,7 +11,7 @@ namespace System.Linq.Dynamic.Core.NewtonsoftJson.Extensions;
 /// </summary>
 internal static class JObjectExtensions
 {
-    private class JTokenResolvers : Dictionary<JTokenType, Func<JToken, DynamicJsonClassOptions?, object?>>;
+    private sealed class JTokenResolvers : Dictionary<JTokenType, Func<JToken, DynamicJsonClassOptions?, object?>>;
 
     private static readonly JTokenResolvers Resolvers = new()
     {
@@ -57,7 +57,7 @@ private class JTokenResolvers : Dictionary<JTokenType, Func<JToken, DynamicJsonC
 
     internal static IEnumerable ToDynamicJsonClassArray(this JArray? src, DynamicJsonClassOptions? options = null)
     {
-        return src == null ? new object?[0] : ConvertJTokenArray(src, options);
+        return src == null ? EmptyArray<object?>.Value : ConvertJTokenArray(src, options);
     }
 
     private static object? ConvertJObject(JToken arg, DynamicJsonClassOptions? options = null)

src/System.Linq.Dynamic.Core.NewtonsoftJson/NewtonsoftJsonExtensions.cs

@@ -874,12 +874,12 @@ private static IQueryable ToQueryable(JArray source, NewtonsoftJsonParsingConfig
         config = config ?? NewtonsoftJsonParsingConfig.Default;
         config.ConvertObjectToSupportComparison = true;
 
-        var normalized = config.Normalize == true ?
+        var normalized = config.Normalize ?
             NormalizeUtils.NormalizeArray(source, config.NormalizationNonExistingPropertyValueBehavior) :
             source;
 
         return normalized
-            .ToDynamicJsonClassArray(config?.DynamicJsonClassOptions)
+            .ToDynamicJsonClassArray(config.DynamicJsonClassOptions)
             .AsQueryable();
     }
     #endregion

src/System.Linq.Dynamic.Core.SystemTextJson/Extensions/JsonDocumentExtensions.cs

@@ -8,7 +8,7 @@ namespace System.Linq.Dynamic.Core.SystemTextJson.Extensions;
 
 internal static class JsonDocumentExtensions
 {
-    private class JTokenResolvers : Dictionary<JsonValueKind, Func<JsonElement, DynamicJsonClassOptions?, object?>>;
+    private sealed class JTokenResolvers : Dictionary<JsonValueKind, Func<JsonElement, DynamicJsonClassOptions?, object?>>;
 
     private static readonly JTokenResolvers Resolvers = new()
     {

src/System.Linq.Dynamic.Core.SystemTextJson/Utils/NormalizeUtils.cs

@@ -155,7 +155,7 @@ private static JsonObject CreateEmptyObject(Dictionary<string, JsonValueInfo> sc
         };
     }
 
-    private static JsonNode? GetNullValue(JsonValueInfo jType)
+    private static JsonValue? GetNullValue(JsonValueInfo jType)
     {
         return jType.Type switch
         {

src/System.Linq.Dynamic.Core/Compatibility/EmptyArray.cs

@@ -0,0 +1,11 @@
+// ReSharper disable once CheckNamespace
+namespace System;
+
+internal static class EmptyArray<T>
+{
+#if NET35 || NET40 || NET45 || NET452
+    public static readonly T[] Value = [];
+#else
+    public static readonly T[] Value = Array.Empty<T>();
+#endif
+}

src/System.Linq.Dynamic.Core/DynamicClassFactory.cs

@@ -462,7 +462,7 @@ private static void EmitEqualityOperators(TypeBuilder typeBuilder, MethodBuilder
 
         ILGenerator ilNeq = inequalityOperator.GetILGenerator();
 
-        // return !(left == right);
+        // Define return !(left == right);
         ilNeq.Emit(OpCodes.Ldarg_0);
         ilNeq.Emit(OpCodes.Ldarg_1);
         ilNeq.Emit(OpCodes.Call, equalityOperator);

src/System.Linq.Dynamic.Core/Extensions/ListExtensions.cs

@@ -5,6 +5,7 @@ namespace System.Linq.Dynamic.Core.Extensions;
 internal static class ListExtensions
 {
     internal static void AddIfNotNull<T>(this IList<T> list, T? value)
+        where T : class
     {
         if (value != null)
         {

src/System.Linq.Dynamic.Core/Parser/ExpressionHelper.cs

@@ -540,7 +540,7 @@ private static Expression GenerateStaticMethodCall(string methodName, Expression
             right = Expression.Convert(right, parameterTypeRight);
         }
 
-        return Expression.Call(null, methodInfo, [left, right]);
+        return Expression.Call(null, methodInfo, left, right);
     }
 
     private static bool TryGetStaticMethod(string methodName, Expression left, Expression right, [NotNullWhen(true)] out MethodInfo? methodInfo)

src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs

@@ -1980,7 +1980,7 @@ private bool TryFindPropertyOrField(Type type, string id, Expression? expression
         switch (member)
         {
             case PropertyInfo property:
-                var propertyIsStatic = property?.GetGetMethod().IsStatic ?? property?.GetSetMethod().IsStatic ?? false;
+                var propertyIsStatic = property.GetGetMethod()?.IsStatic ?? property.GetSetMethod()?.IsStatic ?? false;
                 propertyOrFieldExpression = propertyIsStatic ? Expression.Property(null, property) : Expression.Property(expression, property);
                 return true;
 
@@ -2545,7 +2545,7 @@ private static Exception IncompatibleOperandsError(string opName, Expression lef
         var bindingFlags = BindingFlags.Public | BindingFlags.DeclaredOnly | extraBindingFlag;
         foreach (Type t in TypeHelper.GetSelfAndBaseTypes(type))
         {
-            var findMembersType = _parsingConfig?.IsCaseSensitive == true ? Type.FilterName : Type.FilterNameIgnoreCase;
+            var findMembersType = _parsingConfig.IsCaseSensitive ? Type.FilterName : Type.FilterNameIgnoreCase;
             var members = t.FindMembers(MemberTypes.Property | MemberTypes.Field, bindingFlags, findMembersType, memberName);
 
             if (members.Length != 0)
@@ -2555,7 +2555,7 @@ private static Exception IncompatibleOperandsError(string opName, Expression lef
         }
         return null;
 #else
-        var isCaseSensitive = _parsingConfig.IsCaseSensitive == true;
+        var isCaseSensitive = _parsingConfig.IsCaseSensitive;
         foreach (Type t in TypeHelper.GetSelfAndBaseTypes(type))
         {
             // Try to find a property with the specified memberName

src/System.Linq.Dynamic.Core/Parser/SupportedMethods/MethodFinder.cs

@@ -10,7 +10,7 @@ internal class MethodFinder
 {
     private readonly ParsingConfig _parsingConfig;
     private readonly IExpressionHelper _expressionHelper;
-    private readonly IDictionary<Type, MethodInfo[]> _cachedMethods;
+    private readonly Dictionary<Type, MethodInfo[]> _cachedMethods;
 
     /// <summary>
     /// #794