Fix error when parsing nested object initialization (issue #701)

Agent-Logs-Url: https://github.com/zzzprojects/System.Linq.Dynamic.Core/sessions/4683789c-0227-43d7-9432-4863adea1d4c

Co-authored-by: StefH <249938+StefH@users.noreply.github.com>

Author: Copilot

src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs

@@ -1678,14 +1678,67 @@ private Expression CreateNewExpression(List<DynamicProperty> properties, List<Ex
                 propertyOrFieldType = fieldInfo.FieldType;
             }
 
-            // Call Promote and if that returns false, just try to convert the expression to the destination type using Expression.Convert
-            var promoted = _parsingConfig.ExpressionPromoter.Promote(expressions[i], propertyOrFieldType, true, true) ?? Expression.Convert(expressions[i], propertyOrFieldType);
-            memberBindings[i] = Expression.Bind(memberInfo, promoted);
+            // Call Promote and if that returns null, try to rebuild a nested MemberInitExpression for the target type,
+            // and if that also fails, try to convert the expression to the destination type using Expression.Convert.
+            var promoted = _parsingConfig.ExpressionPromoter.Promote(expressions[i], propertyOrFieldType, true, true);
+            if (promoted == null && expressions[i] is MemberInitExpression memberInitExpression)
+            {
+                promoted = TryRebuildMemberInitExpression(memberInitExpression, propertyOrFieldType);
+            }
+            memberBindings[i] = Expression.Bind(memberInfo, promoted ?? Expression.Convert(expressions[i], propertyOrFieldType));
         }
 
         return Expression.MemberInit(Expression.New(type), memberBindings);
     }
 
+    private static Expression? TryRebuildMemberInitExpression(MemberInitExpression memberInitExpression, Type targetType)
+    {
+        var defaultConstructor = targetType.GetConstructor(Type.EmptyTypes);
+        if (defaultConstructor == null)
+        {
+            return null;
+        }
+
+        var newBindings = new MemberBinding[memberInitExpression.Bindings.Count];
+        for (var i = 0; i < memberInitExpression.Bindings.Count; i++)
+        {
+            if (memberInitExpression.Bindings[i] is not MemberAssignment assignment)
+            {
+                return null;
+            }
+
+            var memberName = assignment.Member.Name;
+            MemberInfo? targetMember = targetType.GetProperty(memberName) ?? (MemberInfo?)targetType.GetField(memberName);
+            if (targetMember == null)
+            {
+                return null;
+            }
+
+            var targetMemberType = targetMember is PropertyInfo targetPropertyInfo
+                ? targetPropertyInfo.PropertyType
+                : ((FieldInfo)targetMember).FieldType;
+
+            var bindingExpression = assignment.Expression;
+            if (bindingExpression is MemberInitExpression nestedMemberInit && bindingExpression.Type != targetMemberType)
+            {
+                var rebuilt = TryRebuildMemberInitExpression(nestedMemberInit, targetMemberType);
+                if (rebuilt == null)
+                {
+                    return null;
+                }
+                bindingExpression = rebuilt;
+            }
+            else if (bindingExpression.Type != targetMemberType)
+            {
+                bindingExpression = Expression.Convert(bindingExpression, targetMemberType);
+            }
+
+            newBindings[i] = Expression.Bind(targetMember, bindingExpression);
+        }
+
+        return Expression.MemberInit(Expression.New(targetType), newBindings);
+    }
+
     private Expression ParseLambdaInvocation(LambdaExpression lambda)
     {
         int errorPos = _textParser.CurrentToken.Pos;

test/System.Linq.Dynamic.Core.Tests/DynamicExpressionParserTests.cs

@@ -2303,6 +2303,35 @@ public void DynamicExpressionParser_ParseLambda_LambdaParameter_SameNameAsDynami
         DynamicExpressionParser.ParseLambda<bool>(new ParsingConfig(), false, "new[]{1,2,3}.Any(z => z > 0)");
     }
 
+    // https://github.com/zzzprojects/System.Linq.Dynamic.Core/issues/701
+    [Fact]
+    public void DynamicExpressionParser_ParseLambda_NestedObjectInitialization()
+    {
+        // Arrange
+        var srcType = typeof(CustomerForNestedNewTest);
+
+        // Act
+        var lambda = DynamicExpressionParser.ParseLambda(ParsingConfig.DefaultEFCore21, srcType, srcType, "new (new (3 as Id) as CurrentDepartment)");
+        var @delegate = lambda.Compile();
+        var result = (CustomerForNestedNewTest)@delegate.DynamicInvoke(new CustomerForNestedNewTest())!;
+
+        // Assert
+        result.Should().NotBeNull();
+        result.CurrentDepartment.Should().NotBeNull();
+        result.CurrentDepartment!.Id.Should().Be(3);
+    }
+
+    public class CustomerForNestedNewTest
+    {
+        public int Id { get; set; }
+        public DepartmentForNestedNewTest? CurrentDepartment { get; set; }
+    }
+
+    public class DepartmentForNestedNewTest
+    {
+        public int Id { get; set; }
+    }
+
     public class DefaultDynamicLinqCustomTypeProviderForGenericExtensionMethod : DefaultDynamicLinqCustomTypeProvider
     {
         public DefaultDynamicLinqCustomTypeProviderForGenericExtensionMethod() : base(ParsingConfig.Default)